Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags()

Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags()

To diagnose the cause of crashes on WebView.

BUG=514141
Committed: https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1
Cr-Commit-Position: refs/heads/master@{#358295}

[bashi, 2015-11-06 04:14:05]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org

[bashi, 2015-11-06 04:14:06]

Haraken-san, WDYT?

[haraken, 2015-11-06 04:24:09]

LGTM

https://codereview.chromium.org/1419023008/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/PartitionAlloc.h (right):

https://codereview.chromium.org/1419023008/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/PartitionAlloc.h:749: RELEASE_ASSERT(bucket >=
&root->buckets[0] && bucket <= &root->buckets[kGenericNumBuckets-1]);

It would be more helpful to split the assert into two asserts.

RELEASE_ASSERT(bucket >= &root->buckets[0]);
RELEASE_ASSERT(&root->buckets[kGenericNumBuckets-1]);

Add spaces around '-'.

[bashi, 2015-11-06 04:40:38]

https://codereview.chromium.org/1419023008/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/PartitionAlloc.h (right):

https://codereview.chromium.org/1419023008/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/PartitionAlloc.h:749: RELEASE_ASSERT(bucket >=
&root->buckets[0] && bucket <= &root->buckets[kGenericNumBuckets-1]);
On 2015/11/06 04:24:09, haraken wrote:
> 
> It would be more helpful to split the assert into two asserts.
> 
> RELEASE_ASSERT(bucket >= &root->buckets[0]);
> RELEASE_ASSERT(&root->buckets[kGenericNumBuckets-1]);
> 
> Add spaces around '-'.

Done.

[bashi, 2015-11-06 04:41:22]

The CQ bit was checked by bashi@chromium.org

[bashi, 2015-11-06 04:41:22]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1419023008/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2015-11-06 04:42:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419023008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419023008/20001

[bashi, 2015-11-06 10:01:17]

The CQ bit was checked by bashi@chromium.org

[bashi, 2015-11-06 10:01:18]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1419023008/#ps40001
(title: " ")

[bashi, 2015-11-06 10:01:25]

https://codereview.chromium.org/1419023008/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/PartitionAlloc.h (right):

https://codereview.chromium.org/1419023008/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/PartitionAlloc.h:749: RELEASE_ASSERT(bucket >=
&root->buckets[0] || bucket == &PartitionRootGeneric::gPagedBucket);
bucket can be &PartitionRootGeneric::gPageBucket

[commit-bot: I haz the power, 2015-11-06 10:02:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419023008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419023008/40001

[commit-bot: I haz the power, 2015-11-06 10:07:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-06 10:07:54]

Patchset 3 (id:??) landed as
https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1
Cr-Commit-Position: refs/heads/master@{#358295}

[Torne, 2016-10-24 13:34:58]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2444913002/ by torne@chromium.org.

The reason for reverting is: Asserts no longer necessary; the bug is due to
blink reinitialisation (which is now prevented elsewhere) not an internal
problem with PartitionAlloc..