Add bluetoothPrivate.connect

extensions/common/api/bluetooth_private.idl

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use the <code>chrome.bluetoothPrivate</code> API to control the Bluetooth
 // adapter state and handle device pairing.
 // NOTE: This IDL is dependent on bluetooth.idl.
 
 [implemented_in = "extensions/browser/api/bluetooth/bluetooth_private_api.h"]
 
@@ skipping 25 matching lines @@
     confirmPasskey,
 
     // Requests authorization for a pairing under the just-works model. It is up
     // to the app to ask for user confirmation.
     requestAuthorization,
 
     // Pairing is completed.
     complete
   };
 
+  // Results for connect().
+  enum ConnectResultType {

[Devlin, 2015/10/29 18:26:45]

Results are only given if the function succeeds; otherwise, lastError is set. 
Having an error result type doesn't make sense, because developers will never
see the error in the result.

[stevenjb, 2015/10/29 19:10:12]

You're right, I need to change the implementation to succeed and return the
result on a connect error. Done and documented.

+    success,
+    unknownError,
+    inProgress,
+    failed,
+    authFailed,
+    authCanceled,
+    authRejected,
+    authTimeout,
+    unsupportedDevice
+  };
+
   // Valid pairing responses.
   enum PairingResponse {
     confirm, reject, cancel
   };
 
   enum TransportType {
     le, bredr, dual
   };
 
   // A pairing event received from a Bluetooth device.
@@ skipping 42 matching lines @@
     // RSSI ranging value. Only devices with RSSI higher than this value will be
     // reported.
     long? rssi;
 
     // Pathloss ranging value. Only devices with pathloss lower than this value
     // will be reported.
     long? pathloss;
   };
 
   callback VoidCallback = void();
+  callback ConnectCallback = void(ConnectResultType result);
 
   // These functions all report failures via chrome.runtime.lastError.
   interface Functions {
     // Changes the state of the Bluetooth adapter.
     // |adapterState|:
     static void setAdapterState(NewAdapterState adapterState,
                                 optional VoidCallback callback);
 
     static void setPairingResponse(SetPairingResponseOptions options,
                                    optional VoidCallback callback);
 
     // Tears down all connections to the given device.
     static void disconnectAll(DOMString deviceAddress,
                               optional VoidCallback callback);
 
     // Set or clear discovery filter.
     static void setDiscoveryFilter(DiscoveryFilter discoveryFilter,
                                    optional VoidCallback callback);
 
+    // Connects to the given device.
+    static void connect(DOMString deviceAddress,
+                        optional ConnectCallback callback);
+
     // Pairs the given device.
     static void pair(DOMString deviceAddress, optional VoidCallback callback);
   };
 
   interface Events {
     // Fired when a pairing event occurs.
     // |pairingEvent|: A pairing event.
     [maxListeners=1] static void onPairing(PairingEvent pairingEvent);
   };
 };