Issue 1419013006: VM: Fix bug with CHA-based inlining in --noopt mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1419013006: VM: Fix bug with CHA-based inlining in --noopt mode. (Closed)

Created:
5 years, 1 month ago by Florian Schneider

Modified:
5 years, 1 month ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix bug with CHA-based inlining in --noopt mode. Use propagated cids (not abstract types) only to specialize instance calls. BUG=dartbug.com/24789 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e75056ccb495c1970fcacd56a15ab1f7da4cb97b

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -46 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+39 lines, -40 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/standalone.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Florian Schneider

5 years, 1 month ago (2015-11-02 18:48:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e75056ccb495c1970fcacd56a15ab1f7da4cb97b (presubmit successful).