Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Side by Side Diff: src/interpreter/bytecode-generator.h

Issue 1419003002: [Interpreter] Unify global and unallocated variable access. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix unallocated variable error Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INTERPRETER_BYTECODE_GENERATOR_H_ 5 #ifndef V8_INTERPRETER_BYTECODE_GENERATOR_H_
6 #define V8_INTERPRETER_BYTECODE_GENERATOR_H_ 6 #define V8_INTERPRETER_BYTECODE_GENERATOR_H_
7 7
8 #include "src/ast.h" 8 #include "src/ast.h"
9 #include "src/interpreter/bytecode-array-builder.h" 9 #include "src/interpreter/bytecode-array-builder.h"
10 #include "src/interpreter/bytecodes.h" 10 #include "src/interpreter/bytecodes.h"
(...skipping 24 matching lines...) Expand all
35 class EffectResultScope; 35 class EffectResultScope;
36 class AccumulatorResultScope; 36 class AccumulatorResultScope;
37 class RegisterResultScope; 37 class RegisterResultScope;
38 38
39 void MakeBytecodeBody(); 39 void MakeBytecodeBody();
40 Register NextContextRegister() const; 40 Register NextContextRegister() const;
41 41
42 DEFINE_AST_VISITOR_SUBCLASS_MEMBERS(); 42 DEFINE_AST_VISITOR_SUBCLASS_MEMBERS();
43 43
44 Register VisitArguments(ZoneList<Expression*>* arguments); 44 Register VisitArguments(ZoneList<Expression*>* arguments);
45
45 void VisitArithmeticExpression(BinaryOperation* binop); 46 void VisitArithmeticExpression(BinaryOperation* binop);
46 void VisitCommaExpression(BinaryOperation* binop); 47 void VisitCommaExpression(BinaryOperation* binop);
47 void VisitLogicalOrExpression(BinaryOperation* binop); 48 void VisitLogicalOrExpression(BinaryOperation* binop);
48 void VisitLogicalAndExpression(BinaryOperation* binop); 49 void VisitLogicalAndExpression(BinaryOperation* binop);
50
49 void VisitPropertyLoad(Register obj, Property* expr); 51 void VisitPropertyLoad(Register obj, Property* expr);
52 void VisitPropertyLoadForAccumulator(Register obj, Property* expr);
53
50 void VisitVariableLoad(Variable* variable, FeedbackVectorSlot slot); 54 void VisitVariableLoad(Variable* variable, FeedbackVectorSlot slot);
51 void VisitVariableAssignment(Variable* variable, FeedbackVectorSlot slot); 55 void VisitVariableAssignment(Variable* variable, FeedbackVectorSlot slot);
56
52 void VisitNewLocalFunctionContext(); 57 void VisitNewLocalFunctionContext();
53 void VisitBuildLocalActivationContext(); 58 void VisitBuildLocalActivationContext();
54 void VisitNewLocalBlockContext(Scope* scope); 59 void VisitNewLocalBlockContext(Scope* scope);
55 void VisitFunctionClosureForContext(); 60 void VisitFunctionClosureForContext();
56 void VisitSetHomeObject(Register value, Register home_object, 61 void VisitSetHomeObject(Register value, Register home_object,
57 ObjectLiteralProperty* property, int slot_number = 0); 62 ObjectLiteralProperty* property, int slot_number = 0);
58 void VisitObjectLiteralAccessor(Register home_object, 63 void VisitObjectLiteralAccessor(Register home_object,
59 ObjectLiteralProperty* property, 64 ObjectLiteralProperty* property,
60 Register value_out); 65 Register value_out);
61 66
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 123
119 int binary_expression_depth_; 124 int binary_expression_depth_;
120 ZoneSet<int> binary_expression_hazard_set_; 125 ZoneSet<int> binary_expression_hazard_set_;
121 }; 126 };
122 127
123 } // namespace interpreter 128 } // namespace interpreter
124 } // namespace internal 129 } // namespace internal
125 } // namespace v8 130 } // namespace v8
126 131
127 #endif // V8_INTERPRETER_BYTECODE_GENERATOR_H_ 132 #endif // V8_INTERPRETER_BYTECODE_GENERATOR_H_
OLDNEW
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698