Issue 14190019: Allow null assignments if there is a corresponding marker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14190019: Allow null assignments if there is a corresponding marker. (Closed)

Created:
7 years, 8 months ago by Anton Muhin

Modified:
7 years, 8 months ago

Reviewers:
podivlov, podivilov1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow null assignments if there is a corresponding marker. R=podivlov@chromium.org BUG=10025 Committed: https://code.google.com/p/dart/source/detail?r=22067

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -4 lines)			Patch
	M	tests/html/input_element_test.dart	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
	M	tools/dom/scripts/systemnative.py	View		1 chunk	+16 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

podivilov1

lgtm https://codereview.chromium.org/14190019/diff/1/tests/html/input_element_test.dart File tests/html/input_element_test.dart (right): https://codereview.chromium.org/14190019/diff/1/tests/html/input_element_test.dart#newcode182 tests/html/input_element_test.dart:182: test('value = null', () { test name might ...

7 years, 8 months ago (2013-04-26 08:14:05 UTC) #2

Anton Muhin

https://codereview.chromium.org/14190019/diff/1/tests/html/input_element_test.dart File tests/html/input_element_test.dart (right): https://codereview.chromium.org/14190019/diff/1/tests/html/input_element_test.dart#newcode182 tests/html/input_element_test.dart:182: test('value = null', () { On 2013/04/26 08:14:05, podivilov1 ...

7 years, 8 months ago (2013-04-26 08:47:53 UTC) #3

Anton Muhin

7 years, 8 months ago (2013-04-26 08:48:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22067 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14190019: Allow null assignments if there is a corresponding marker. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages