Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1418983003: bug fix for odd width 16/24 bit to i420 (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

bug fix for odd width 16/24 bit to i420 A bug was introduced on arm when the code for 'any' width switch to a temporary stack buffer and simd. The C version handles odd width by doing 1 pixel, instead of averaging 2. But the SIMD any version is supposed to replicate the last pixel, then the subsampling in Neon will average the pixel with itself, producing the same result. The previous version did this, but only for ARGB 32 bit, which was to avoid introducing issues with subsampled YUY2 source. This CL adds replication for RGB 16 bit values. TBR=harryjin@google.com BUG=libyuv:510 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/90335f604395321eadae07157aede2a54da821de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M source/row_any.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fbarchard1
5 years, 2 months ago (2015-10-22 01:22:55 UTC) #1
fbarchard1
5 years, 2 months ago (2015-10-22 01:23:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
90335f604395321eadae07157aede2a54da821de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698