Error reporting for spans.

pkg/analyzer/test/generated/all_the_rest_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.all_the_rest_test;
 
 import 'package:analyzer/file_system/physical_file_system.dart';
 import 'package:analyzer/src/generated/ast.dart' hide ConstantEvaluator;
 import 'package:analyzer/src/generated/constant.dart';
 import 'package:analyzer/src/generated/element.dart';
@@ skipping 13 matching lines @@
 import 'package:analyzer/src/generated/testing/ast_factory.dart';
 import 'package:analyzer/src/generated/testing/element_factory.dart';
 import 'package:analyzer/src/generated/testing/html_factory.dart';
 import 'package:analyzer/src/generated/testing/test_type_provider.dart';
 import 'package:analyzer/src/generated/testing/token_factory.dart';
 import 'package:analyzer/src/generated/utilities_collection.dart';
 import 'package:analyzer/src/generated/utilities_dart.dart';
 import 'package:analyzer/src/task/dart.dart';
 import 'package:path/path.dart';
 import 'package:unittest/unittest.dart';
+import 'package:yaml/yaml.dart';
 
 import '../reflective_tests.dart';
 import '../utils.dart';
 import 'engine_test.dart';
 import 'parser_test.dart';
 import 'resolver_test.dart';
 import 'test_support.dart';
 
 main() {
   initializeTestEnvironment();
@@ skipping 7248 matching lines @@
    * @param typeName the name of the type to be created
    * @return the type that was created
    */
   InterfaceType createType(String fileName, String typeName) {
     CompilationUnitElementImpl unit = ElementFactory.compilationUnit(fileName);
     ClassElementImpl element = ElementFactory.classElement2(typeName);
     unit.types = <ClassElement>[element];
     return element.type;
   }
 
+  void test_reportErrorForSpan() {
+    GatheringErrorListener listener = new GatheringErrorListener();
+    ErrorReporter reporter = new ErrorReporter(
+        listener,
+        new NonExistingSource(

[Brian Wilkerson, 2015/10/22 00:13:00]

It's not a problem for this test because you're not actually accessing the
content, but we generally only use NonExistingSource when we care about the
source throwing an exception when we try to access the content. Otherwise we
generally use TestSource.

+            '/test.yaml', toUri('/test.yaml'), UriKind.FILE_URI));
+
+    var src = '''
+foo: bar
+zap: baz
+''';
+
+    YamlMap node = loadYamlNode(src);
+    YamlNode bazNode = node.nodes['zap'];

[scheglov, 2015/10/21 23:47:21]

I think YAML adds extra complexity here.
Why not create SourceSpan directly and pass it in?

[pquitslund, 2015/10/21 23:56:57]

Mainly because I want to ensure that the spans that are created by yaml parsing
use offsets that agree with our expectations (e.g., not 1-based).  If I create
the span myself I won't be able to test that.   I guess I'm kind of sneaking
some integration testing in here....  If you have other ideas for where I should
move this, I'm all ears!

[Brian Wilkerson, 2015/10/22 00:13:00]

Technically, testing whether the yaml parser produces the right offsets should
be in the yaml package :-) If you really don't trust the yaml parser, then let's
create a directory for tests of code from other packages (like
"test/dependencies/yaml" and put them in there.

+    reporter.reportErrorForSpan(AnalysisOptionsWarningCode.UNSUPPORTED_OPTION,
+        bazNode.span, ['test', 'zap']);
+    expect(listener.errors, hasLength(1));
+    expect(listener.errors.first.offset, src.indexOf('baz'));
+    expect(listener.errors.first.length, 'baz'.length);
+  }
+
   void test_creation() {
     GatheringErrorListener listener = new GatheringErrorListener();
     TestSource source = new TestSource();
     expect(new ErrorReporter(listener, source), isNotNull);
   }
 
   void test_reportErrorForElement_named() {
     DartType type = createType("/test1.dart", "A");
     ClassElement element = type.element;
     GatheringErrorListener listener = new GatheringErrorListener();
@@ skipping 2079 matching lines @@
     if (_expectedExternalScriptName == null) {
       expect(scriptSource, isNull, reason: "script $scriptIndex");
     } else {
       expect(scriptSource, isNotNull, reason: "script $scriptIndex");
       String actualExternalScriptName = scriptSource.shortName;
       expect(actualExternalScriptName, _expectedExternalScriptName,
           reason: "script $scriptIndex");
     }
   }
 }