src/regexp/regexp-macro-assembler-tracer.h - Issue 1418963009: Experimental support for RegExp lookbehind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/regexp/regexp-macro-assembler-tracer.h

Issue 1418963009: Experimental support for RegExp lookbehind. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressed comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/regexp/regexp-macro-assembler-tracer.h

diff --git a/src/regexp/regexp-macro-assembler-tracer.h b/src/regexp/regexp-macro-assembler-tracer.h

index f9364195fa7683cce977e3cd491ea019c0f2ff25..3a94ee80bdb601422111091adb303c72e92d423c 100644

--- a/src/regexp/regexp-macro-assembler-tracer.h

+++ b/src/regexp/regexp-macro-assembler-tracer.h

@@ -30,9 +30,11 @@ class RegExpMacroAssemblerTracer: public RegExpMacroAssembler {

virtual void CheckCharacterGT(uc16 limit, Label* on_greater);

virtual void CheckCharacterLT(uc16 limit, Label* on_less);

virtual void CheckGreedyLoop(Label* on_tos_equals_current_position);

- virtual void CheckNotAtStart(Label* on_not_at_start);

- virtual void CheckNotBackReference(int start_reg, Label* on_no_match);

+ virtual void CheckNotAtStart(int cp_offset, Label* on_not_at_start);

+ virtual void CheckNotBackReference(int start_reg, bool read_backward,

+ Label* on_no_match);

virtual void CheckNotBackReferenceIgnoreCase(int start_reg,

+ bool read_backward,

Label* on_no_match);

virtual void CheckNotCharacter(unsigned c, Label* on_not_equal);

virtual void CheckNotCharacterAfterAnd(unsigned c,