cc/trees/proxy_impl.h - Issue 1418953002: cc: Send shared variables between main and impl side using the channel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/proxy_impl.h

Issue 1418953002: cc: Send shared variables between main and impl side using the channel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/proxy_impl.h

diff --git a/cc/trees/proxy_impl.h b/cc/trees/proxy_impl.h

index 8acbb97377e108ce58d5849b55c47ca131d35709..c1598cc595cdfa09c66dd91464b072a5e78085f1 100644

--- a/cc/trees/proxy_impl.h

+++ b/cc/trees/proxy_impl.h

@@ -43,7 +43,12 @@ class CC_EXPORT ProxyImpl {

virtual void MainFrameWillHappenOnImplForTesting(

CompletionEvent* completion,

bool* main_frame_will_happen) = 0;

- virtual void StartCommitOnImpl(CompletionEvent* completion) = 0;

+ virtual void StartCommitOnImpl(CompletionEvent* completion,

+ LayerTreeHost* layer_tree_host,

+ bool hold_commit_for_activation) = 0;

+ virtual void InitializeImplOnImpl(CompletionEvent* completion,

+ LayerTreeHost* layer_tree_host) = 0;

+ virtual void LayerTreeHostClosedOnImpl(CompletionEvent* completion) = 0;

brianderson 2015/10/29 22:38:28 Should bug summary mention anything about this cha

Khushal 2015/10/29 22:52:19 Done.

// TODO(khushalsagar): Rename as GetWeakPtr() once ThreadProxy is split.

virtual base::WeakPtr<ProxyImpl> GetImplWeakPtr() = 0;

« no previous file with comments | « cc/trees/layer_tree_host_unittest_proxy.cc ('k') | cc/trees/thread_proxy.h » ('j') | cc/trees/thread_proxy.cc » ('J')