cc: Send shared variables between main and impl side using the channel

cc/trees/layer_tree_host_unittest_proxy.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "cc/test/fake_content_layer_client.h"
 #include "cc/test/fake_picture_layer.h"
 #include "cc/test/layer_tree_test.h"
 #include "cc/trees/thread_proxy.h"
@@ skipping 269 matching lines @@
     EXPECT_EQ(1, update_check_layer_->update_count());
     EndTest();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ThreadProxyTestSetNeedsCommitWhileAnimating);
 };
 
 THREAD_PROXY_TEST_F(ThreadProxyTestSetNeedsCommitWhileAnimating);
 
+class ThreadProxyTestCommitWaitsForActivation : public ThreadProxyTest {
+ protected:
+  ThreadProxyTestCommitWaitsForActivation() : commits_completed_(0) {}
+  ~ThreadProxyTestCommitWaitsForActivation() override {}
+
+  void BeginTest() override { proxy()->SetNeedsCommit(); }
+
+  void ScheduledActionCommit() override {
+    switch (commits_completed_) {
+      case 0:
+        // The first commit does not wait for activation. Verify that the
+        // completion event is cleared.
+        EXPECT_EQ(nullptr, ThreadProxyImplOnly().commit_completion_event);

[vmpstr, 2015/11/03 19:50:55]

nit: We usually use EXPECT_TRUE/EXPECT_FALSE for nullptr checks.

[Khushal, 2015/11/03 20:03:05]

Done.

+        EXPECT_FALSE(ThreadProxyImplOnly().next_commit_waits_for_activation);
+        break;
+      case 1:
+        // The second commit should be held until activation.
+        EXPECT_NE(nullptr, ThreadProxyImplOnly().commit_completion_event);

[vmpstr, 2015/11/03 19:50:55]

Here as well.

[Khushal, 2015/11/03 20:03:05]

Done.

+        EXPECT_TRUE(ThreadProxyImplOnly().next_commit_waits_for_activation);
+        break;
+      case 2:
+        // The third commit should not wait for activation.
+        EXPECT_EQ(nullptr, ThreadProxyImplOnly().commit_completion_event);

[vmpstr, 2015/11/03 19:50:55]

Here as well.

[Khushal, 2015/11/03 20:03:05]

Done.

+        EXPECT_FALSE(ThreadProxyImplOnly().next_commit_waits_for_activation);
+    }
+  }
+
+  void DidActivateSyncTree() override {
+    // The next_commit_waits_for_activation should have been cleared after the
+    // sync tree is activated.
+    EXPECT_FALSE(ThreadProxyImplOnly().next_commit_waits_for_activation);
+  }
+
+  void DidCommit() override {
+    switch (commits_completed_) {
+      case 0:
+        // The first commit has been completed. Set next commit waits for
+        // activation and start another commit.
+        commits_completed_++;

[David Trainor- moved to gerrit, 2015/11/02 16:19:44]

Pull this out of the switch?  Otherwise if you somehow get more than 3 calls you
won't catch it?

[Khushal, 2015/11/02 17:02:54]

The AfterTest should catch that right? It makes sure that the test gets exactly
3 commits.

+        proxy()->SetNextCommitWaitsForActivation();
+        proxy()->SetNeedsCommit();
+      case 1:
+        // Start another commit to verify that this is not held until
+        // activation.
+        commits_completed_++;
+        proxy()->SetNeedsCommit();
+      case 2:
+        commits_completed_++;
+        EndTest();
+    }
+  }
+
+  void AfterTest() override { EXPECT_EQ(3, commits_completed_); }
+
+ private:
+  int commits_completed_;
+
+  DISALLOW_COPY_AND_ASSIGN(ThreadProxyTestCommitWaitsForActivation);
+};
+
+THREAD_PROXY_TEST_F(ThreadProxyTestCommitWaitsForActivation);
+
 }  // namespace cc