cc/trees/channel_main.h - Issue 1418953002: cc: Send shared variables between main and impl side using the channel

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/trees/channel_main.h

Issue 1418953002: cc: Send shared variables between main and impl side using the channel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « cc/test/layer_tree_test.cc ('k') | cc/trees/layer_tree_host_unittest_proxy.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_TREES_CHANNEL_MAIN_H_	5 #ifndef CC_TREES_CHANNEL_MAIN_H_

6 #define CC_TREES_CHANNEL_MAIN_H_	6 #define CC_TREES_CHANNEL_MAIN_H_

7	7

8 #include "cc/base/cc_export.h"	8 #include "cc/base/cc_export.h"

9 #include "cc/base/completion_event.h"	9 #include "cc/base/completion_event.h"

10 #include "cc/input/top_controls_state.h"	10 #include "cc/input/top_controls_state.h"

(...skipping 26 matching lines...) Expand all Loading...
37 virtual void FinishAllRenderingOnImpl(CompletionEvent* completion) = 0;	37 virtual void FinishAllRenderingOnImpl(CompletionEvent* completion) = 0;

38 virtual void SetVisibleOnImpl(CompletionEvent* completion, bool visible) = 0;	38 virtual void SetVisibleOnImpl(CompletionEvent* completion, bool visible) = 0;

39 virtual void ReleaseOutputSurfaceOnImpl(CompletionEvent* completion) = 0;	39 virtual void ReleaseOutputSurfaceOnImpl(CompletionEvent* completion) = 0;

40 virtual void FinishGLOnImpl(CompletionEvent* completion) = 0;	40 virtual void FinishGLOnImpl(CompletionEvent* completion) = 0;

41 virtual void MainFrameWillHappenOnImplForTesting(	41 virtual void MainFrameWillHappenOnImplForTesting(

42 CompletionEvent* completion,	42 CompletionEvent* completion,

43 bool* main_frame_will_happen) = 0;	43 bool* main_frame_will_happen) = 0;

44 virtual void SetNeedsRedrawOnImpl(const gfx::Rect& damage_rect) = 0;	44 virtual void SetNeedsRedrawOnImpl(const gfx::Rect& damage_rect) = 0;

45 virtual void SetNeedsCommitOnImpl() = 0;	45 virtual void SetNeedsCommitOnImpl() = 0;

46 virtual void BeginMainFrameAbortedOnImpl(CommitEarlyOutReason reason) = 0;	46 virtual void BeginMainFrameAbortedOnImpl(CommitEarlyOutReason reason) = 0;

47 virtual void StartCommitOnImpl(CompletionEvent* completion) = 0;	47 virtual void StartCommitOnImpl(CompletionEvent* completion,
	Khushal 2015/10/23 22:42:29 The aim here is to make it explicit to the user of The aim here is to make it explicit to the user of the channel as to which operations use the LayerTreeHost on the impl side, so for a remote channel, it can be serialized at that point. Alternatively we could add methods to the ChannelImpl, CreateLayerTreeHostImpl(LayerTreeHostImplClient client); FinishCommitToLayerTreeHostImpl(LayerTreeHostImpl host_impl); and the implementation uses the LayerTreeHost to do the operations. Would that be better?
	48 LayerTreeHost* layer_tree_host,

	49 bool hold_commit_for_activation) = 0;

	50 virtual void InitializeImplOnImpl(CompletionEvent* completion,

	51 LayerTreeHost* layer_tree_host) = 0;

	52 virtual void LayerTreeHostClosedOnImpl(CompletionEvent* completion) = 0;

48	53

49 virtual ~ChannelMain() {}	54 virtual ~ChannelMain() {}

50 };	55 };

51	56

52 } // namespace cc	57 } // namespace cc

53	58

54 #endif // CC_TREES_CHANNEL_MAIN_H_	59 #endif // CC_TREES_CHANNEL_MAIN_H_

OLD	NEW