Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: chrome/browser/search/search.h

Issue 141893009: Create a new helper function to extract search terms from the URL irrespective of the availablility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/search.h
diff --git a/chrome/browser/search/search.h b/chrome/browser/search/search.h
index 68ac6d864f792ee1b34f247e58344b83de1ca373..d8af40e396dc35f9997d1f1092ec9a1205b99bcb 100644
--- a/chrome/browser/search/search.h
+++ b/chrome/browser/search/search.h
@@ -78,15 +78,19 @@ bool IsSuggestPrefEnabled(Profile* profile);
// the Instant Extended API is not enabled.
uint64 EmbeddedSearchPageVersion();
-// Returns whether query extraction is enabled.
+// Returns whether query extraction flag is enabled in the field trials.
samarth 2014/02/12 18:02:39 Any reason for changing this comment? I prefer the
kmadhusu 2014/02/12 19:58:09 I just want to distinguish IsQueryExtractionEnable
bool IsQueryExtractionEnabled();
-// Extracts and returns search terms from |url|. Returns empty string if the URL
-// is not secure or doesn't have a search term replacement key. Does not
-// consider IsQueryExtractionEnabled() and Instant support state of the page and
-// does not check for a privileged process, so most callers should use
+// Extracts and returns search terms from |url|. Does not consider
+// IsQueryExtractionEnabled() and Instant support state of the page and does
+// not check for a privileged process, so most callers should use
// GetSearchTerms() below instead.
-base::string16 GetSearchTermsFromURL(Profile* profile, const GURL& url);
+base::string16 ExtractSearchTermsFromURL(Profile* profile, const GURL& url);
+
+// Returns true if it is okay to extract search terms from |url|. |url| must
+// have a secure scheme and must contain the search terms replacement key for
+// the default search provider.
+bool IsQueryExtractionAllowedForURL(Profile* profile, const GURL& url);
// Returns the search terms attached to a specific NavigationEntry, or empty
// string otherwise. Does not consider IsQueryExtractionEnabled() and does not

Powered by Google App Engine
This is Rietveld 408576698