Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: chrome/browser/ui/browser_instant_controller.cc

Issue 141893009: Create a new helper function to extract search terms from the URL irrespective of the availablility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_instant_controller.cc
diff --git a/chrome/browser/ui/browser_instant_controller.cc b/chrome/browser/ui/browser_instant_controller.cc
index ddab4540183761035001486542a359c02fcca053..400c73503104b111d10d83246a5523960d24aa30 100644
--- a/chrome/browser/ui/browser_instant_controller.cc
+++ b/chrome/browser/ui/browser_instant_controller.cc
@@ -73,15 +73,14 @@ bool BrowserInstantController::OpenInstant(WindowOpenDisposition disposition,
// support for the new disposition.
DCHECK(disposition == CURRENT_TAB) << disposition;
- // If we will not be replacing search terms from this URL, don't send to
- // InstantController.
+ Profile* browser_profile = profile();
const base::string16& search_terms =
- chrome::GetSearchTermsFromURL(browser_->profile(), url);
+ chrome::ExtractSearchTermsFromURL(browser_profile, url);
if (search_terms.empty())
return false;
InstantSearchPrerenderer* prerenderer =
- GetInstantSearchPrerenderer(profile());
+ GetInstantSearchPrerenderer(browser_profile);
if (prerenderer) {
if (prerenderer->CanCommitQuery(GetActiveWebContents(), search_terms)) {
// Submit query to render the prefetched results. Browser will swap the
@@ -93,7 +92,10 @@ bool BrowserInstantController::OpenInstant(WindowOpenDisposition disposition,
}
}
- return instant_.SubmitQuery(search_terms);
+ // If we will not be replacing search terms from this URL, don't send to
+ // InstantController.
+ return chrome::IsSuitableURLForInstant(browser_profile, url) ?
Jered 2014/02/11 19:10:10 nit: if (!chrome::IsSuitableURLForInstant(browser_
kmadhusu 2014/02/11 23:24:32 Done.
+ instant_.SubmitQuery(search_terms) : false;
}
Profile* BrowserInstantController::profile() const {

Powered by Google App Engine
This is Rietveld 408576698