Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: chrome/browser/search/instant_unittest_base.cc

Issue 141893009: Create a new helper function to extract search terms from the URL irrespective of the availablility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search/instant_unittest_base.h ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search/instant_unittest_base.cc
diff --git a/chrome/browser/search/instant_unittest_base.cc b/chrome/browser/search/instant_unittest_base.cc
index 80b43f6b0fa268fc3a31496c4d19f626af8b8e93..b45dd19a63dcf8251dd85fc2f01534bb617d9c08 100644
--- a/chrome/browser/search/instant_unittest_base.cc
+++ b/chrome/browser/search/instant_unittest_base.cc
@@ -34,24 +34,8 @@ InstantUnitTestBase::~InstantUnitTestBase() {
}
void InstantUnitTestBase::SetUp() {
- SetUpHelper();
-}
-
-void InstantUnitTestBase::SetUpHelper() {
chrome::EnableQueryExtractionForTesting();
- BrowserWithTestWindowTest::SetUp();
-
- TemplateURLServiceFactory::GetInstance()->SetTestingFactoryAndUse(
- profile(), &TemplateURLServiceFactory::BuildInstanceFor);
- template_url_service_ = TemplateURLServiceFactory::GetForProfile(profile());
- ui_test_utils::WaitForTemplateURLServiceToLoad(template_url_service_);
-
- UIThreadSearchTermsData::SetGoogleBaseURL("https://www.google.com/");
- TestingPrefServiceSyncable* pref_service = profile()->GetTestingPrefService();
- pref_service->SetUserPref(prefs::kLastPromptedGoogleURL,
- new base::StringValue("https://www.google.com/"));
- SetDefaultSearchProvider("{google:baseURL}");
- instant_service_ = InstantServiceFactory::GetForProfile(profile());
+ SetUpHelper();
}
void InstantUnitTestBase::TearDown() {
@@ -59,6 +43,12 @@ void InstantUnitTestBase::TearDown() {
BrowserWithTestWindowTest::TearDown();
}
+#if !defined(OS_IOS) && !defined(OS_ANDROID)
+void InstantUnitTestBase::SetUpWithoutQueryExtraction() {
+ SetUpHelper();
+}
+#endif
+
void InstantUnitTestBase::SetDefaultSearchProvider(
const std::string& base_url) {
TemplateURLData data;
@@ -92,9 +82,23 @@ void InstantUnitTestBase::NotifyGoogleBaseURLUpdate(
content::Details<GoogleURLTracker::UpdatedDetails>(&details));
}
-
bool InstantUnitTestBase::IsInstantServiceObserver(
InstantServiceObserver* observer) {
return instant_service_->observers_.HasObserver(observer);
}
+void InstantUnitTestBase::SetUpHelper() {
+ BrowserWithTestWindowTest::SetUp();
+
+ TemplateURLServiceFactory::GetInstance()->SetTestingFactoryAndUse(
+ profile(), &TemplateURLServiceFactory::BuildInstanceFor);
+ template_url_service_ = TemplateURLServiceFactory::GetForProfile(profile());
+ ui_test_utils::WaitForTemplateURLServiceToLoad(template_url_service_);
+
+ UIThreadSearchTermsData::SetGoogleBaseURL("https://www.google.com/");
+ TestingPrefServiceSyncable* pref_service = profile()->GetTestingPrefService();
+ pref_service->SetUserPref(prefs::kLastPromptedGoogleURL,
+ new base::StringValue("https://www.google.com/"));
+ SetDefaultSearchProvider("{google:baseURL}");
+ instant_service_ = InstantServiceFactory::GetForProfile(profile());
+}
« no previous file with comments | « chrome/browser/search/instant_unittest_base.h ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698