Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 141893002: We no longer need to recover type cells from the oracle. (Closed)

Created:
6 years, 11 months ago by mvstanton
Modified:
6 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

We no longer need to recover type cells from the oracle. We only need the values within them. Function calls to Array from optimized code needed the cell in the past, but no longer. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18682

Patch Set 1 #

Patch Set 2 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -47 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ast.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +3 lines, -10 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/type-info.cc View 2 chunks +6 lines, -13 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Benedikt, one more cleanup in the series on the way to type vector. I ...
6 years, 11 months ago (2014-01-17 17:33:20 UTC) #1
Benedikt Meurer
Nice refactoring. LGTM
6 years, 11 months ago (2014-01-20 08:58:01 UTC) #2
mvstanton
6 years, 11 months ago (2014-01-20 09:48:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r18682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698