Issue 1418923005: Revert "Revert "Add type cast definitions for CPDF_Reference.""

Issue 1418923005: Revert "Revert "Add type cast definitions for CPDF_Reference."" (Closed)

Created:
5 years, 1 month ago by dsinclair

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez, Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Revert "Add type cast definitions for CPDF_Reference."" This reverts commit 7e155865c90cc1115cc7193b7646a341d8f9093e. Add type cast definitions for CPDF_Reference. This Cl adds ToReference, CPDF_Object::AsReference and CPDF_Object::IsReference and updates the src to use them as needed. BUG=pdfium:201 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6ee3484bcb413f4cce303e237fe15e2bdaf51ade

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -233 lines)			Patch
M	core/include/fpdfapi/fpdf_objects.h	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp	View		2 chunks	+6 lines, -14 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp	View		1 chunk	+15 lines, -38 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp	View		2 chunks	+4 lines, -9 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp	View		11 chunks	+43 lines, -64 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	1	15 chunks	+58 lines, -77 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	core/src/fpdfdoc/doc_form.cpp	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	core/src/fpdfdoc/doc_tagged.cpp	View		4 chunks	+14 lines, -16 lines	0 comments	Download
M	fpdfsdk/src/fpdf_flatten.cpp	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	fpdfsdk/src/fpdf_transformpage.cpp	View		3 chunks	+3 lines, -5 lines	0 comments	Download
M	fpdfsdk/src/fpdfppo.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

dsinclair

PTAL. Patch Set 1 is the reverted code, patch set 2 is the fix.

5 years, 1 month ago (2015-10-26 18:01:43 UTC) #2

dsinclair

5 years, 1 month ago (2015-10-26 19:58:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6ee3484bcb413f4cce303e237fe15e2bdaf51ade (presubmit successful).