Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: media/base/audio_converter.cc

Issue 14189035: Reduce jitter from uneven SincResampler buffer size requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/audio_converter_unittest.cc » ('j') | media/base/sinc_resampler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_converter.cc
diff --git a/media/base/audio_converter.cc b/media/base/audio_converter.cc
index ec74e038a3bc7f4ded3073095fb259d451ec8237..d392c6d3f9f0c67e184dab520afcd86d4dc62fa7 100644
--- a/media/base/audio_converter.cc
+++ b/media/base/audio_converter.cc
@@ -55,7 +55,7 @@ AudioConverter::AudioConverter(const AudioParameters& input_params,
resampler_.reset(new MultiChannelResampler(
downmix_early_ ? output_params.channels() :
input_params.channels(),
- io_sample_rate_ratio, base::Bind(
+ io_sample_rate_ratio, 512, base::Bind(
&AudioConverter::ProvideInput, base::Unretained(this))));
}
@@ -72,9 +72,10 @@ AudioConverter::AudioConverter(const AudioParameters& input_params,
// Since the resampler / output device may want a different buffer size than
// the caller asked for, we need to use a FIFO to ensure that both sides
// read in chunk sizes they're configured for.
- if (resampler_.get() ||
+ // TODO(dalecurtis): Update comment.
+ if (!resampler_.get() &&
input_params.frames_per_buffer() != output_params.frames_per_buffer()) {
- DVLOG(1) << "Rebuffering from " << input_params.frames_per_buffer()
+ LOG(ERROR) << "Rebuffering from " << input_params.frames_per_buffer()
<< " to " << output_params.frames_per_buffer();
audio_fifo_.reset(new AudioPullFifo(
downmix_early_ ? output_params.channels() :
« no previous file with comments | « no previous file | media/base/audio_converter_unittest.cc » ('j') | media/base/sinc_resampler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698