Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 14189031: Merge 195349 "Reland "gpu: Fix Vivante's "hisilicon" GPUs"" (Closed)

Created:
7 years, 8 months ago by epenner
Modified:
7 years, 8 months ago
Reviewers:
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Merge 195349 "Reland "gpu: Fix Vivante's "hisilicon" GPUs"" > Reland "gpu: Fix Vivante's "hisilicon" GPUs" > > This fixes "Hisilicon" GPUs, which is an instance of a > Vivante's GPU design. This involves enabling virtual > contexts, since they don't support share-groups, and further > adds a work-around for switching surfaces. Without the work- > around the view surface "inherits" the size of the last > bound surface (which for Chrome tends to be a 1x1 pbuffer) > resulting in a black screen. The following steps "repair" > the view surface every time it is made current: > > - Make it current. > - Bind the default frame-buffer. > - Make it not current. > - Destroy/recreate it from the native handle. > - Make it current again. > > NOTE: The "Recreate" function is added to surface because > the Destroy/Initialize may be intercepted or modified by > wrapper surface classes. Recreate is similar to resize, > which after being forwarded by a wrapper can call > Destroy/Initialize on the 'real' surface. > > BUG=179250 > NOTRY=true > > No-try, as all the relevant bots are already green. > > Review URL: https://chromiumcodereview.appspot.com/13852023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -2 lines) Patch
M content/gpu/gpu_info_collector_android.cc View 2 chunks +3 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 4 chunks +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_context_virtual.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/gl/gl_context.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_context.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_context_egl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gl/gl_context_egl.cc View 3 chunks +47 lines, -1 line 0 comments Download
M ui/gl/gl_surface.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gl/gl_surface.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
epenner
7 years, 8 months ago (2013-04-23 21:59:16 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r195905.

Powered by Google App Engine
This is Rietveld 408576698