Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14189022: chromeos: Fix wrong error handling of SetLargestChangestamp (Closed)

Created:
7 years, 8 months ago by hashimoto
Modified:
7 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Fix wrong error handling of SetLargestChangestamp SetLargestChangestamp can fail when something is wrong with the disk. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195439

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/drive/change_list_processor.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
7 years, 8 months ago (2013-04-19 10:57:24 UTC) #1
kinaba
lgtm
7 years, 8 months ago (2013-04-19 11:03:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14189022/1
7 years, 8 months ago (2013-04-19 11:06:50 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-19 11:08:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14189022/1
7 years, 8 months ago (2013-04-21 08:19:08 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-21 08:27:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14189022/1
7 years, 8 months ago (2013-04-22 03:20:00 UTC) #7
hashimoto
7 years, 8 months ago (2013-04-22 04:25:22 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 manually as r195439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698