Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 14189012: Use new Windows close icon and renamed expand icons in notifications. (Closed)

Created:
7 years, 8 months ago by dharcourt
Modified:
7 years, 8 months ago
Reviewers:
oshima, dewittj
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Use new Windows close icon and renamed expand icons in notifications. Changes code to use the images committed with http://crrev.com/14362011. BUG=232963 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195404

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M ui/message_center/views/message_view.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/resources/ui_resources.grd View 1 2 3 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
dharcourt
Justin for overall review. Mitsuru for OWNERS review of .grd change. Thanks! - Charles
7 years, 8 months ago (2013-04-19 19:42:04 UTC) #1
dewittj
lgtm
7 years, 8 months ago (2013-04-19 21:54:06 UTC) #2
oshima
lgtm
7 years, 8 months ago (2013-04-19 23:27:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14189012/4005
7 years, 8 months ago (2013-04-19 23:50:21 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-19 23:51:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14189012/4005
7 years, 8 months ago (2013-04-20 00:57:36 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=8620
7 years, 8 months ago (2013-04-20 02:29:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14189012/4005
7 years, 8 months ago (2013-04-20 02:32:59 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 02:41:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14189012/4005
7 years, 8 months ago (2013-04-20 02:44:16 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 02:50:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14189012/4005
7 years, 8 months ago (2013-04-20 03:26:01 UTC) #12
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 03:32:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14189012/4005
7 years, 8 months ago (2013-04-20 04:45:48 UTC) #14
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 04:51:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14189012/26005
7 years, 8 months ago (2013-04-20 05:54:22 UTC) #16
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 06:07:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14189012/26005
7 years, 8 months ago (2013-04-20 06:19:36 UTC) #18
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 06:26:09 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14189012/26005
7 years, 8 months ago (2013-04-20 14:00:01 UTC) #20
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 14:07:30 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14189012/26005
7 years, 8 months ago (2013-04-20 17:17:36 UTC) #22
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 17:23:18 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14189012/26005
7 years, 8 months ago (2013-04-20 22:10:27 UTC) #24
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-20 22:17:48 UTC) #25
dharcourt
7 years, 8 months ago (2013-04-20 22:55:56 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 manually as r195404 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698