Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: chrome/browser/resources/options/options.js

Issue 14189011: Remove instant confirmation dialog that is displayed the first time the instant checkbox is clicked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove prefs::InstantConfirmDialogShown Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/resources/options/options.html ('k') | chrome/browser/search/search.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var AddLanguageOverlay = options.AddLanguageOverlay; 5 var AddLanguageOverlay = options.AddLanguageOverlay;
6 var AlertOverlay = options.AlertOverlay; 6 var AlertOverlay = options.AlertOverlay;
7 var AutofillEditAddressOverlay = options.AutofillEditAddressOverlay; 7 var AutofillEditAddressOverlay = options.AutofillEditAddressOverlay;
8 var AutofillEditCreditCardOverlay = options.AutofillEditCreditCardOverlay; 8 var AutofillEditCreditCardOverlay = options.AutofillEditCreditCardOverlay;
9 var AutofillOptions = options.AutofillOptions; 9 var AutofillOptions = options.AutofillOptions;
10 var BrowserOptions = options.BrowserOptions; 10 var BrowserOptions = options.BrowserOptions;
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 OptionsPage.registerOverlay( 79 OptionsPage.registerOverlay(
80 new ConfirmDialog( 80 new ConfirmDialog(
81 'doNotTrackConfirm', 81 'doNotTrackConfirm',
82 loadTimeData.getString('doNotTrackConfirmOverlayTabTitle'), 82 loadTimeData.getString('doNotTrackConfirmOverlayTabTitle'),
83 'do-not-track-confirm-overlay', 83 'do-not-track-confirm-overlay',
84 $('do-not-track-confirm-ok'), 84 $('do-not-track-confirm-ok'),
85 $('do-not-track-confirm-cancel'), 85 $('do-not-track-confirm-cancel'),
86 $('do-not-track-enabled').pref, 86 $('do-not-track-enabled').pref,
87 $('do-not-track-enabled').metric), 87 $('do-not-track-enabled').metric),
88 BrowserOptions.getInstance()); 88 BrowserOptions.getInstance());
89 OptionsPage.registerOverlay(
90 new ConfirmDialog(
91 'instantConfirm',
92 loadTimeData.getString('instantConfirmOverlayTabTitle'),
93 'instantConfirmOverlay',
94 $('instantConfirmOk'),
95 $('instantConfirmCancel'),
96 $('instant-enabled-control').pref,
97 $('instant-enabled-control').metric,
98 'instant.confirm_dialog_shown'),
99 BrowserOptions.getInstance());
100 // 'spelling-enabled-control' element is only present on Chrome branded 89 // 'spelling-enabled-control' element is only present on Chrome branded
101 // builds. 90 // builds.
102 if ($('spelling-enabled-control')) { 91 if ($('spelling-enabled-control')) {
103 OptionsPage.registerOverlay( 92 OptionsPage.registerOverlay(
104 new ConfirmDialog( 93 new ConfirmDialog(
105 'spellingConfirm', 94 'spellingConfirm',
106 loadTimeData.getString('spellingConfirmOverlayTabTitle'), 95 loadTimeData.getString('spellingConfirmOverlayTabTitle'),
107 'spelling-confirm-overlay', 96 'spelling-confirm-overlay',
108 $('spelling-confirm-ok'), 97 $('spelling-confirm-ok'),
109 $('spelling-confirm-cancel'), 98 $('spelling-confirm-cancel'),
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
282 options.OptionsPage.willClose(); 271 options.OptionsPage.willClose();
283 }; 272 };
284 273
285 /** 274 /**
286 * Listener for the |popstate| event. 275 * Listener for the |popstate| event.
287 * @param {Event} e The |popstate| event. 276 * @param {Event} e The |popstate| event.
288 */ 277 */
289 window.onpopstate = function(e) { 278 window.onpopstate = function(e) {
290 options.OptionsPage.setState(e.state); 279 options.OptionsPage.setState(e.state);
291 }; 280 };
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/options.html ('k') | chrome/browser/search/search.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698