linux_aura: Implement dropping in chrome.

linux_aura: Implement dropping in chrome.

This patch makes dropping text and files onto the omnibox work in linux_aura
builds of chrome. The parts that implement dragging out of chrome still don't
work.

BUG=130806
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194677

[sky, 2013-04-12 20:12:11]

I'm assuming Dan is going to review the X changes in detail. Only have nits,
LGTM once fixed.

https://codereview.chromium.org/14189002/diff/17004/ui/base/dragdrop/os_excha...
File ui/base/dragdrop/os_exchange_data_provider_aurax11.h (right):

https://codereview.chromium.org/14189002/diff/17004/ui/base/dragdrop/os_excha...
ui/base/dragdrop/os_exchange_data_provider_aurax11.h:90: bool
GetPlainTextURL(GURL* url) const;;
;; -> ;

https://codereview.chromium.org/14189002/diff/17004/ui/base/dragdrop/os_excha...
ui/base/dragdrop/os_exchange_data_provider_aurax11.h:106: bool own_window_;
const

https://codereview.chromium.org/14189002/diff/17004/ui/base/x/selection_utils.h
File ui/base/x/selection_utils.h (right):

https://codereview.chromium.org/14189002/diff/17004/ui/base/x/selection_utils...
ui/base/x/selection_utils.h:101: };
DISALLOW_COPY_AND_ASSIGN?

https://codereview.chromium.org/14189002/diff/17004/ui/ui.gyp
File ui/ui.gyp (right):

https://codereview.chromium.org/14189002/diff/17004/ui/ui.gyp#newcode148
ui/ui.gyp:148: 'base/dragdrop/os_exchange_data_provider_aurax11.cc',
nit: sort

[Daniel Erat, 2013-04-13 02:15:00]

LGTM with comments

https://codereview.chromium.org/14189002/diff/39001/ui/base/dragdrop/os_excha...
File ui/base/dragdrop/os_exchange_data_provider_aurax11.cc (right):

https://codereview.chromium.org/14189002/diff/39001/ui/base/dragdrop/os_excha...
ui/base/dragdrop/os_exchange_data_provider_aurax11.cc:52:
atom_cache_.GetAtom("XdndSelection")),
nit: use kDndSelection here

https://codereview.chromium.org/14189002/diff/39001/ui/base/dragdrop/os_excha...
ui/base/dragdrop/os_exchange_data_provider_aurax11.cc:54:
atom_cache_.GetAtom("XdndSelection")),
nit: use kDndSelection here

https://codereview.chromium.org/14189002/diff/39001/ui/base/dragdrop/os_excha...
ui/base/dragdrop/os_exchange_data_provider_aurax11.cc:79:
atom_cache_.GetAtom("XdndSelection")),
and here

https://codereview.chromium.org/14189002/diff/39001/ui/base/dragdrop/os_excha...
ui/base/dragdrop/os_exchange_data_provider_aurax11.cc:81:
atom_cache_.GetAtom("XdndSelection")) {
and here

https://codereview.chromium.org/14189002/diff/39001/ui/base/dragdrop/os_excha...
ui/base/dragdrop/os_exchange_data_provider_aurax11.cc:135: if (data.get()) {
nit: think you can just use "if (data)" now

https://codereview.chromium.org/14189002/diff/39001/ui/base/dragdrop/os_excha...
ui/base/dragdrop/os_exchange_data_provider_aurax11.cc:152: if (data.get()) {
same here

https://codereview.chromium.org/14189002/diff/39001/ui/base/dragdrop/os_excha...
File ui/base/dragdrop/os_exchange_data_provider_aurax11.h (right):

https://codereview.chromium.org/14189002/diff/39001/ui/base/dragdrop/os_excha...
ui/base/dragdrop/os_exchange_data_provider_aurax11.h:104: // available (in the
case of drag receiving). Othertimes, we need to create
nit: s/Othertimes/other times/

https://codereview.chromium.org/14189002/diff/39001/ui/base/dragdrop/os_excha...
ui/base/dragdrop/os_exchange_data_provider_aurax11.h:105: // our own xwindow
just to receive events on it.
nit: s/xwindow/X window/

https://codereview.chromium.org/14189002/diff/39001/ui/views/widget/desktop_a...
File ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc (right):

https://codereview.chromium.org/14189002/diff/39001/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:56:
~X11DragContext();
virtual

https://codereview.chromium.org/14189002/diff/39001/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:83: };
DISALLOW_COPY_AND_ASSIGN (unless this needs to be copyable)

https://codereview.chromium.org/14189002/diff/39001/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:341:
DCHECK(window == target_window_);
DCHECK_EQ?

https://codereview.chromium.org/14189002/diff/39001/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:401: return
atom_cache_.GetAtom("XdndActionCopy");
mind moving these to constants?  they look like they get used a few times in
this file

https://codereview.chromium.org/14189002/diff/39001/ui/views/widget/desktop_a...
File ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h (right):

https://codereview.chromium.org/14189002/diff/39001/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h:85: // the
underlying aura::Window representation. In the case of
nit: fix partial sentence at the end of this comment

https://codereview.chromium.org/14189002/diff/39001/ui/views/widget/desktop_a...
ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h:133: // 
scoped_refptr<ui::DragSource> drag_source_;
delete this

[Elliot Glaysher, 2013-04-17 21:13:42]

Committed patchset #6 manually as r194677 (presubmit successful).