Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1418863002: SkRemote: refactoring (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkRemote: refactoring - Cache becomes CachingEncoder that wraps another Encoder - Encoders provide IDs - syntaxy improvements to Client - ID isn't really protocol sensitive. - I don't think we need Type::kNone. No diffs. https://gold.skia.org/search2?issue=1418863002&unt=true&query=source_type%3Dgm&master=false&include=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b6b8f2727f6b08bbc307aeebac23beeba1e4984f

Patch Set 1 #

Patch Set 2 : ID is not protocol sensitive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -260 lines) Patch
M dm/DMSrcSink.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M src/core/SkRemote.h View 1 8 chunks +53 lines, -56 lines 0 comments Download
M src/core/SkRemote.cpp View 4 chunks +109 lines, -175 lines 0 comments Download
M src/core/SkRemote_protocol.h View 1 2 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418863002/20001
5 years, 2 months ago (2015-10-21 16:46:45 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-21 16:56:15 UTC) #6
mtklein_C
5 years, 2 months ago (2015-10-21 16:59:57 UTC) #8
hal.canary
lgtm
5 years, 2 months ago (2015-10-21 17:45:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418863002/20001
5 years, 2 months ago (2015-10-21 17:45:09 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 17:46:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b6b8f2727f6b08bbc307aeebac23beeba1e4984f

Powered by Google App Engine
This is Rietveld 408576698