Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: runtime/vm/profiler_service.cc

Issue 1418833004: VM: Service isolate under precompilation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/precompiler.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler_service.cc
diff --git a/runtime/vm/profiler_service.cc b/runtime/vm/profiler_service.cc
index 7ea7d3b129cc138ebf54bb7b7f3494861c74cffb..4e371794ca55f50128f9d594f34be0c78b54fef5 100644
--- a/runtime/vm/profiler_service.cc
+++ b/runtime/vm/profiler_service.cc
@@ -1876,6 +1876,16 @@ class ProfileBuilder : public ValueObject {
code.compile_timestamp(),
code);
}
+ // Precompiled instructions are in the VM isolate, but the code (except
+ // stubs) is in the current isolate.
+ code ^= Code::LookupCode(pc);
+ if (!code.IsNull()) {
+ return new ProfileCode(ProfileCode::kDartCode,
+ code.EntryPoint(),
+ code.EntryPoint() + code.Size(),
+ code.compile_timestamp(),
+ code);
+ }
return new ProfileCode(ProfileCode::kCollectedCode,
pc,
(pc & kDartCodeAlignmentMask) + kDartCodeAlignment,
« no previous file with comments | « runtime/vm/precompiler.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698