Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 141883002: Fix an issue found in https://chromiumcodereview.appspot.com/23205008/ (Closed)

Created:
6 years, 11 months ago by Devlin
Modified:
6 years, 11 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Yoyo Zhou
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix an issue found in https://chromiumcodereview.appspot.com/23205008/ Min granularity was still not being calculated right. Fix it again and add a unit test. BUG=268300 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245611

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M chrome/browser/extensions/api/alarms/alarm_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/alarms/alarm_manager.cc View 1 chunk +3 lines, -3 lines 1 comment Download
M chrome/browser/extensions/api/alarms/alarms_api_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
https://codereview.chromium.org/141883002/diff/1/chrome/browser/extensions/api/alarms/alarm_manager.cc File chrome/browser/extensions/api/alarms/alarm_manager.cc (right): https://codereview.chromium.org/141883002/diff/1/chrome/browser/extensions/api/alarms/alarm_manager.cc#newcode331 chrome/browser/extensions/api/alarms/alarm_manager.cc:331: base::TimeDelta cur_alarm_delta = cur_alarm_time - last_poll_time_; Slight tweak from ...
6 years, 11 months ago (2014-01-17 17:25:04 UTC) #1
Devlin
6 years, 11 months ago (2014-01-17 17:25:05 UTC) #2
Matt Perry
lgtm
6 years, 11 months ago (2014-01-17 18:57:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/141883002/1
6 years, 11 months ago (2014-01-17 19:06:38 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 20:53:27 UTC) #5
Message was sent while issue was closed.
Change committed as 245611

Powered by Google App Engine
This is Rietveld 408576698