Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1418823005: [turbofan] Disable general purpose inlining with asm.js code. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Disable general purpose inlining with asm.js code. This adapts the general purpose inlining heuristic to not inline within or across the boundary of asm.js code. Note that this only affects the heuristics, from a functional point of view it is still supported. R=bmeurer@chromium.org BUG=chromium:549000 LOG=n Committed: https://crrev.com/5fc75b26b3a233f67d00f216feaa10ab404a06aa Cr-Commit-Position: refs/heads/master@{#31654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/compiler/js-inlining-heuristic.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
5 years, 1 month ago (2015-10-29 10:25:24 UTC) #1
Michael Starzinger
Ooops, forgot to specify a reviewer. :)
5 years, 1 month ago (2015-10-29 13:01:05 UTC) #4
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-10-29 13:14:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418823005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418823005/1
5 years, 1 month ago (2015-10-29 13:36:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 13:38:39 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 13:39:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fc75b26b3a233f67d00f216feaa10ab404a06aa
Cr-Commit-Position: refs/heads/master@{#31654}

Powered by Google App Engine
This is Rietveld 408576698