Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: runtime/vm/object.cc

Issue 1418813008: This adds a mechanism to invalidate code that was generated in the background. The invalidation can… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: sync Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/weak_code.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index d2f3a499143ca7a949a0cbaa43b89384da360770..0a3b9ec1d2e5881eede608462431e4c0d2b11d92 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -2890,6 +2890,10 @@ class CHACodeArray : public WeakCodeReferences {
}
}
+ virtual void IncrementInvalidationGen() {
+ Isolate::Current()->IncrCHAInvalidationGen();
+ }
+
private:
const Class& cls_;
DISALLOW_COPY_AND_ASSIGN(CHACodeArray);
@@ -7774,6 +7778,10 @@ class FieldDependentArray : public WeakCodeReferences {
}
}
+ virtual void IncrementInvalidationGen() {
+ Isolate::Current()->IncrFieldInvalidationGen();
+ }
+
private:
const Field& field_;
DISALLOW_COPY_AND_ASSIGN(FieldDependentArray);
@@ -10815,6 +10823,10 @@ class PrefixDependentArray : public WeakCodeReferences {
}
}
+ virtual void IncrementInvalidationGen() {
+ Isolate::Current()->IncrPrefixInvalidationGen();
+ }
+
private:
const LibraryPrefix& prefix_;
DISALLOW_COPY_AND_ASSIGN(PrefixDependentArray);
@@ -17051,9 +17063,9 @@ void Number::PrintJSONImpl(JSONStream* stream, bool ref) const {
const char* Integer::ToCString() const {
- // Integer is an interface. No instances of Integer should exist.
- UNREACHABLE();
- return "Integer";
+ // Integer is an interface. No instances of Integer should exist except null.
+ ASSERT(IsNull());
+ return "NULL Integer";
}
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/weak_code.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698