third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp - Issue 1418813004: [Fetch API] Reflect spec changes of bodyUsed property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp

Issue 1418813004: [Fetch API] Reflect spec changes of bodyUsed property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/fetch/Body.cpp ('K') | « third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp ('k') | third_party/WebKit/Source/modules/fetch/Request.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp b/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp

index 27ddb4605ce01ec74f97d4922bbf995f31debf96..67242fe2f2e3c620217532d177b75e8acc0b5478 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp

@@ -183,8 +183,7 @@ FetchResponseData* FetchResponseData::clone(ExecutionContext* executionContext)

ASSERT(!m_internalResponse);

if (m_buffer) {

OwnPtr<WebDataConsumerHandle> handle1, handle2;

- // TODO(yhirano): unlock the buffer appropriately.

- DataConsumerTee::create(executionContext, m_buffer->lock(executionContext), &handle1, &handle2);

+ DataConsumerTee::create(executionContext, m_buffer->releaseHandle(executionContext), &handle1, &handle2);

m_buffer = new BodyStreamBuffer(createFetchDataConsumerHandleFromWebHandle(handle1.release()));

newResponse->m_buffer = new BodyStreamBuffer(createFetchDataConsumerHandleFromWebHandle(handle2.release()));

}