third_party/WebKit/Source/modules/fetch/Body.h - Issue 1418813004: [Fetch API] Reflect spec changes of bodyUsed property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/Body.h

Issue 1418813004: [Fetch API] Reflect spec changes of bodyUsed property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/cachestorage/Cache.cpp ('k') | third_party/WebKit/Source/modules/fetch/Body.cpp » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/Body.h

diff --git a/third_party/WebKit/Source/modules/fetch/Body.h b/third_party/WebKit/Source/modules/fetch/Body.h

index 1e9ee5374eb14ee5d5a8cdba5b51b8c763dc7da7..ea53d878d3fea7c93dcd6d3aa453e86a59c09cc9 100644

--- a/third_party/WebKit/Source/modules/fetch/Body.h

+++ b/third_party/WebKit/Source/modules/fetch/Body.h

@@ -19,6 +19,13 @@ class ExecutionContext;

class ReadableByteStream;

class ScriptState;

+// This class represents Body mix-in defined in the fetch spec

+// https://fetch.spec.whatwg.org/#body-mixin.

+//

+// Note: This class has body stream and its predicate whereas in the current

+// spec only Response has it and Request has a byte stream defined in the

+// Encoding spec. The spec should be fixed shortly to be aligned with this

+// implementation.

class MODULES_EXPORT Body

: public GarbageCollectedFinalized<Body>

, public ScriptWrappable

@@ -35,12 +42,12 @@ public:

ScriptPromise formData(ScriptState*);

ScriptPromise json(ScriptState*);

ScriptPromise text(ScriptState*);

- ReadableByteStream* body();

+ ReadableByteStream* bodyWithUseCounter();

virtual BodyStreamBuffer* bodyBuffer() = 0;

virtual const BodyStreamBuffer* bodyBuffer() const = 0;

- bool bodyUsed();

- void setBodyPassed() { m_bodyPassed = true; }

+ virtual bool bodyUsed();

+ bool isBodyLocked();

// ActiveDOMObject override.

bool hasPendingActivity() const override;

@@ -51,9 +58,8 @@ public:

}

private:

+ ReadableByteStream* body();

virtual String mimeType() const = 0;

- bool m_bodyPassed;

};

} // namespace blink