Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 14188057: Add some additional network debugging code (Closed)

Created:
7 years, 8 months ago by stevenjb
Modified:
7 years, 8 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Add some additional network debugging code BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196428

Patch Set 1 #

Total comments: 2

Patch Set 2 : Shorten name #

Patch Set 3 : Less state spam #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M ash/system/chromeos/network/tray_network.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/network/network_state_handler.cc View 1 2 3 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
stevenjb
A couple of small changes to improve our network debugging. jamescook@ for ash/ gspencer@ for ...
7 years, 8 months ago (2013-04-24 22:16:27 UTC) #1
Greg Spencer (Chromium)
lgtm
7 years, 8 months ago (2013-04-24 22:20:13 UTC) #2
James Cook
ash/* LGTM with nit https://codereview.chromium.org/14188057/diff/1/ash/system/chromeos/network/tray_network.cc File ash/system/chromeos/network/tray_network.cc (right): https://codereview.chromium.org/14188057/diff/1/ash/system/chromeos/network/tray_network.cc#newcode135 ash/system/chromeos/network/tray_network.cc:135: return "ash/system/chromeos/network/NetworkTrayView"; nit: I think ...
7 years, 8 months ago (2013-04-24 22:47:34 UTC) #3
stevenjb
https://codereview.chromium.org/14188057/diff/1/ash/system/chromeos/network/tray_network.cc File ash/system/chromeos/network/tray_network.cc (right): https://codereview.chromium.org/14188057/diff/1/ash/system/chromeos/network/tray_network.cc#newcode135 ash/system/chromeos/network/tray_network.cc:135: return "ash/system/chromeos/network/NetworkTrayView"; On 2013/04/24 22:47:34, James Cook (Chromium) wrote: ...
7 years, 8 months ago (2013-04-24 22:53:24 UTC) #4
stevenjb
gspencer@ - PTAL I'm trying to eliminate redundant information and noticed that we were logging ...
7 years, 8 months ago (2013-04-24 23:18:47 UTC) #5
Greg Spencer (Chromium)
Still LGTM
7 years, 8 months ago (2013-04-24 23:28:52 UTC) #6
stevenjb
7 years, 8 months ago (2013-04-25 17:46:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r196428 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698