gpu: Change Produce/ConsumeTexture to allow texture sharing

gpu/command_buffer/service/mailbox_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/mailbox_manager.h"
 
 #include <algorithm>
 
 #include "base/rand_util.h"
 #include "crypto/hmac.h"
 #include "gpu/command_buffer/service/gl_utils.h"

[no sievers, 2013/05/24 01:31:38]

nit: I think gl_utils.h is not needed anymore.

[piman, 2013/05/24 02:32:22]

Done.

-#include "gpu/command_buffer/service/texture_definition.h"
+#include "gpu/command_buffer/service/texture_manager.h"
 
 namespace gpu {
 namespace gles2 {
 
 MailboxName::MailboxName() {
   std::fill(key, key + sizeof(key), 0);
   std::fill(signature, signature + sizeof(signature), 0);
 }
 
 MailboxManager::MailboxManager()
     : hmac_(crypto::HMAC::SHA256),
       textures_(std::ptr_fun(&MailboxManager::TargetNameLess)) {
   base::RandBytes(private_key_, sizeof(private_key_));
   bool success = hmac_.Init(
       base::StringPiece(private_key_, sizeof(private_key_)));
   DCHECK(success);
   DCHECK(!IsMailboxNameValid(MailboxName()));
 }
 
 MailboxManager::~MailboxManager() {
   DCHECK(!textures_.size());
 }
 
 void MailboxManager::GenerateMailboxName(MailboxName* name) {
   base::RandBytes(name->key, sizeof(name->key));
   SignMailboxName(name);
 }
 
-TextureDefinition* MailboxManager::ConsumeTexture(unsigned target,
-                                                  const MailboxName& name) {
+Texture* MailboxManager::ConsumeTexture(unsigned target,
+                                        const MailboxName& name) {
   if (!IsMailboxNameValid(name))
     return NULL;
 
-  TextureDefinitionMap::iterator it =
-      textures_.find(TargetName(target, name));
+  TextureMap::iterator it = textures_.find(TargetName(target, name));
   if (it == textures_.end())
     return NULL;
 
-  TextureDefinition* definition = it->second.definition.release();
-  textures_.erase(it);
-
-  return definition;
+  return it->second;
 }
 
 bool MailboxManager::ProduceTexture(unsigned target,
                                     const MailboxName& name,
-                                    TextureDefinition* definition,
-                                    TextureManager* owner) {
+                                    Texture* texture) {
   if (!IsMailboxNameValid(name))
     return false;
 
-  TextureDefinitionMap::iterator it =
-      textures_.find(TargetName(target, name));
-  if (it != textures_.end()) {
-    NOTREACHED();
-    GLuint service_id = it->second.definition->ReleaseServiceId();
-    glDeleteTextures(1, &service_id);
-    it->second = OwnedTextureDefinition(definition, owner);
-  } else {
-    textures_.insert(std::make_pair(
-        TargetName(target, name),
-        OwnedTextureDefinition(definition, owner)));
-  }
+  texture->SetMailboxManager(this);
+  TextureMap::iterator it = textures_.find(TargetName(target, name));
+  if (it != textures_.end())
+    it->second = texture;
+  else
+    textures_.insert(std::make_pair(TargetName(target, name), texture));
 
   return true;
 }
 
-void MailboxManager::DestroyOwnedTextures(TextureManager* owner,
-                                          bool have_context) {
-  TextureDefinitionMap::iterator it = textures_.begin();
+void MailboxManager::TextureDeleted(Texture* texture) {
+  TextureMap::iterator it = textures_.begin();
   while (it != textures_.end()) {

[apatrick_chromium, 2013/05/23 18:37:11]

This might now be a more common operation. Before this would only happen on
context group destruction. Now if happens whenever the last ref to a Texture
goes away. Could add a multiset with the reverse mapping Texture->TargetName or
something. Maybe not for this patch.

[piman, 2013/05/24 02:32:22]

Done.

-    TextureDefinitionMap::iterator current_it = it;
+    TextureMap::iterator current_it = it;
     ++it;
-    if (current_it->second.owner == owner) {
-      GLuint service_id = current_it->second.definition->ReleaseServiceId();
-      if (have_context)
-        glDeleteTextures(1, &service_id);
+    if (current_it->second == texture)
       textures_.erase(current_it);
-    }
   }
 }
 
 void MailboxManager::SignMailboxName(MailboxName* name) {
   bool success = hmac_.Sign(
       base::StringPiece(reinterpret_cast<char*>(name->key), sizeof(name->key)),
       reinterpret_cast<unsigned char*>(name->signature),
       sizeof(name->signature));
   DCHECK(success);
 }
 
 bool MailboxManager::IsMailboxNameValid(const MailboxName& name) {
   return hmac_.Verify(
       base::StringPiece(reinterpret_cast<const char*>(name.key),
           sizeof(name.key)),
       base::StringPiece(reinterpret_cast<const char*>(name.signature),
           sizeof(name.signature)));
 }
 
 MailboxManager::TargetName::TargetName(unsigned target, const MailboxName& name)
     : target(target),
       name(name) {
 }
 
 bool MailboxManager::TargetNameLess(const MailboxManager::TargetName& lhs,
                                     const MailboxManager::TargetName& rhs) {
   return memcmp(&lhs, &rhs, sizeof(lhs)) < 0;
 }
 
-MailboxManager::OwnedTextureDefinition::OwnedTextureDefinition(
-    TextureDefinition* definition,
-    TextureManager* owner)
-    : definition(definition),
-      owner(owner) {
-}
-
-MailboxManager::OwnedTextureDefinition::~OwnedTextureDefinition() {
-}
-
 }  // namespace gles2
 }  // namespace gpu