Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(345)

Issue 14188048: add installation instructions to pkg packages (Closed)

Created:
7 years, 3 months ago by sethladd
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

add installation instructions to pkg packages BUG= Committed: https://code.google.com/p/dart/source/detail?r=21770

Patch Set 1 #

Total comments: 14

Patch Set 2 : tweaks from review #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -3 lines) Patch
M pkg/args/lib/args.dart View 1 2 chunks +14 lines, -0 lines 0 comments Download
M pkg/http/lib/http.dart View 1 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/intl/lib/intl.dart View 1 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/logging/lib/logging.dart View 1 1 chunk +16 lines, -0 lines 3 comments Download
M pkg/meta/lib/meta.dart View 1 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/oauth2/lib/oauth2.dart View 1 2 chunks +16 lines, -0 lines 0 comments Download
M pkg/pathos/lib/path.dart View 1 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/scheduled_test/lib/scheduled_test.dart View 1 2 chunks +16 lines, -0 lines 0 comments Download
M pkg/serialization/lib/serialization.dart View 1 2 chunks +16 lines, -0 lines 0 comments Download
M pkg/source_maps/lib/source_maps.dart View 1 2 chunks +18 lines, -0 lines 0 comments Download
M pkg/stack_trace/lib/stack_trace.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/unittest/lib/matcher.dart View 1 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/unittest/lib/mock.dart View 1 2 chunks +16 lines, -0 lines 0 comments Download
M pkg/unittest/lib/unittest.dart View 1 2 chunks +16 lines, -3 lines 0 comments Download
M pkg/webdriver/lib/webdriver.dart View 1 2 chunks +18 lines, -0 lines 0 comments Download
M pkg/yaml/lib/yaml.dart View 1 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sethladd
7 years, 3 months ago (2013-04-19 19:10:38 UTC) #1
sethladd
We received notes from the hackathon that people didn't know how to get these libraries, ...
7 years, 3 months ago (2013-04-19 19:11:00 UTC) #2
Andrei Mouravski
Please respond to my comment in args, but fix the same stuff in all of ...
7 years, 3 months ago (2013-04-19 20:13:35 UTC) #3
sethladd
https://codereview.chromium.org/14188048/diff/1/pkg/args/lib/args.dart File pkg/args/lib/args.dart (right): https://codereview.chromium.org/14188048/diff/1/pkg/args/lib/args.dart#newcode17 pkg/args/lib/args.dart:17: * And then run `pub install`. The reference to ...
7 years, 3 months ago (2013-04-19 20:32:43 UTC) #4
Andrei Mouravski
lgtm It would be really awesome if you could generate this common text for everything ...
7 years, 3 months ago (2013-04-19 20:36:09 UTC) #5
sethladd
https://codereview.chromium.org/14188048/diff/11001/pkg/logging/lib/logging.dart File pkg/logging/lib/logging.dart (right): https://codereview.chromium.org/14188048/diff/11001/pkg/logging/lib/logging.dart#newcode24 pkg/logging/lib/logging.dart:24: * [pkg]: http://pub.dartlang.org/packages/logging ? this is used is the ...
7 years, 3 months ago (2013-04-19 20:39:21 UTC) #6
sethladd
Committed patchset #2 manually as r21770 (presubmit successful).
7 years, 3 months ago (2013-04-19 20:51:20 UTC) #7
Andrei Mouravski
7 years, 3 months ago (2013-04-19 20:52:58 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/14188048/diff/11001/pkg/logging/lib/logging.dart
File pkg/logging/lib/logging.dart (right):

https://codereview.chromium.org/14188048/diff/11001/pkg/logging/lib/logging.d...
pkg/logging/lib/logging.dart:24: * [pkg]:
http://pub.dartlang.org/packages/logging
On 2013/04/19 20:39:21, sethladd wrote:
> ? this is used is the rest of the files.

Not the ones before this file (intl, http, args, etc.)

Powered by Google App Engine
This is Rietveld 408576698