MediaStream API: Remove LocalMediaStream

MediaStream API: Remove LocalMediaStream
The subclass LocalMediaStream have been removed from the getusermedia specification:
http://dev.w3.org/2011/webrtc/editor/getusermedia.html

The stop method will be moved temporarily to MediaStream until MediaStreamTrack has been updated.

BUG=233545
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149002

[Tommy Widenflycht, 2013-04-19 12:45:18]

Chris: I had to slightly rewrite a bit of the WebAudio code but the
functionality should still be the same.

[abarth-chromium, 2013-04-19 16:24:03]

LGTM.  Please wait for crogers to give the thumbs up for the webaudio parts of
this change.

[Chris Rogers, 2013-04-19 18:20:28]

https://codereview.chromium.org/14188039/diff/1/Source/modules/webaudio/Audio...
File Source/modules/webaudio/AudioContext.cpp (right):

https://codereview.chromium.org/14188039/diff/1/Source/modules/webaudio/Audio...
Source/modules/webaudio/AudioContext.cpp:402: // FIXME: get a provider for
non-local MediaStreams (like from a remote peer).
We can't just stop checking for isLocal() since we need to distinguish the case
between a locally derived stream (from getUserMedia()) versus a MediaStream from
a remote peer or a MediaStream that has just been created which is non-related
to getUserMedia().

We're gaining access to the hardware here, so need to be careful it's a
"getUserMedia()" approved stream.

[Tommy Widenflycht, 2013-04-22 07:45:23]

https://codereview.chromium.org/14188039/diff/1/Source/modules/webaudio/Audio...
File Source/modules/webaudio/AudioContext.cpp (right):

https://codereview.chromium.org/14188039/diff/1/Source/modules/webaudio/Audio...
Source/modules/webaudio/AudioContext.cpp:402: // FIXME: get a provider for
non-local MediaStreams (like from a remote peer).
The MediaStream is loosing in importance for every release of the spec and can
now be considered to be just a container; especially after the introduction of a
copy constructor. For example one can clone a LocalMediaStream so that it has
the same local tracks but fails the old test. MediaStreamTracks are the new
hotness.

Only local tracks are assigned a deviceId and as long as that is true my new
version of this function actually is more accurate by iterating over all the
tracks and using the first local one. Adding the isLocal() to a MST might be
better though.

On 2013/04/19 18:20:28, Chris Rogers wrote:
> We can't just stop checking for isLocal() since we need to distinguish the
case
> between a locally derived stream (from getUserMedia()) versus a MediaStream
from
> a remote peer or a MediaStream that has just been created which is non-related
> to getUserMedia().
> 
> We're gaining access to the hardware here, so need to be careful it's a
> "getUserMedia()" approved stream.

[Chris Rogers, 2013-04-22 17:38:24]

https://codereview.chromium.org/14188039/diff/1/Source/modules/webaudio/Audio...
File Source/modules/webaudio/AudioContext.cpp (right):

https://codereview.chromium.org/14188039/diff/1/Source/modules/webaudio/Audio...
Source/modules/webaudio/AudioContext.cpp:408: provider =
destination()->localAudioInputProvider();
Tommi, thanks for clarifying - seems fine then except I think we should "break"
here after finding the 1st one

[Tommy Widenflycht, 2013-04-23 11:38:53]

https://codereview.chromium.org/14188039/diff/1/Source/modules/webaudio/Audio...
File Source/modules/webaudio/AudioContext.cpp (right):

https://codereview.chromium.org/14188039/diff/1/Source/modules/webaudio/Audio...
Source/modules/webaudio/AudioContext.cpp:408: provider =
destination()->localAudioInputProvider();
Doh, thanks. break added.
On 2013/04/22 17:38:24, Chris Rogers wrote:
> Tommi, thanks for clarifying - seems fine then except I think we should
"break"
> here after finding the 1st one

[Chris Rogers, 2013-04-23 20:06:09]

Thanks Tommy - lgtm

[commit-bot: I haz the power, 2013-04-24 10:39:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/14188039/10001

[commit-bot: I haz the power, 2013-04-24 10:39:49]

Failed to apply patch for Source/modules/mediastream/MediaStream.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/modules/mediastream/MediaStream.cpp
  Hunk #1 FAILED at 33.
  1 out of 3 hunks FAILED -- saving rejects to file
Source/modules/mediastream/MediaStream.cpp.rej

Patch:       Source/modules/mediastream/MediaStream.cpp
Index: Source/modules/mediastream/MediaStream.cpp
diff --git a/Source/modules/mediastream/MediaStream.cpp
b/Source/modules/mediastream/MediaStream.cpp
index
c183835791a77aeafd6bb18160eb9fca47ca3e7f..e0ec25c5cd5efc8a7d72878077ded13a101b54b9
100644
--- a/Source/modules/mediastream/MediaStream.cpp
+++ b/Source/modules/mediastream/MediaStream.cpp
@@ -33,7 +33,6 @@
 #include "MediaStreamCenter.h"
 #include "MediaStreamSource.h"
 #include "MediaStreamTrackEvent.h"
-#include "UUID.h"
 
 namespace WebCore {
 
@@ -58,7 +57,7 @@ static void processTrack(MediaStreamTrack* track,
MediaStreamSourceVector& sourc
 
 static PassRefPtr<MediaStream> createFromSourceVectors(ScriptExecutionContext*
context, const MediaStreamSourceVector& audioSources, const
MediaStreamSourceVector& videoSources)
 {
-    RefPtr<MediaStreamDescriptor> descriptor =
MediaStreamDescriptor::create(createCanonicalUUIDString(), audioSources,
videoSources);
+    RefPtr<MediaStreamDescriptor> descriptor =
MediaStreamDescriptor::create(audioSources, videoSources);
     MediaStreamCenter::instance().didCreateMediaStream(descriptor.get());
 
     return MediaStream::create(context, descriptor.release());
@@ -221,6 +220,16 @@ MediaStreamTrack* MediaStream::getTrackById(String id)
     return 0;
 }
 
+void MediaStream::stop()
+{
+    if (ended())
+        return;
+
+    MediaStreamCenter::instance().didStopLocalMediaStream(descriptor());
+
+    streamEnded();
+}
+
 void MediaStream::trackEnded()
 {
     for (size_t i = 0; i < m_audioTracks.size(); ++i)

[commit-bot: I haz the power, 2013-04-24 11:52:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/14188039/22004

[commit-bot: I haz the power, 2013-04-24 12:41:36]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-04-24 13:02:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/14188039/22004

[commit-bot: I haz the power, 2013-04-24 13:15:50]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[Tommy Widenflycht, 2013-04-24 13:41:09]

Committed patchset #4 manually as r149002 (presubmit successful).

[ojan, 2013-04-24 20:32:49]

FYI, this patch was reverted.

http://src.chromium.org/viewvc/blink?revision=149030&view=revision