chrome/browser/ui/webui/options/reset_profile_settings_handler.cc - Issue 1418803004: MD Settings: Migrating C++ handlers for profile reset page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

Issue 1418803004: MD Settings: Migrating C++ handlers for profile reset page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: renaming handler to to fix GN build Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/reset_page/reset_page.js ('k') | chrome/browser/ui/webui/settings/md_settings_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

diff --git a/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc b/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

index f8503024eef5c363f4e4259a6df50961dccaa0cc..1d69d5f17b14ccd57661b6a492726b94fc1a7a84 100644

--- a/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

+++ b/chrome/browser/ui/webui/options/reset_profile_settings_handler.cc

@@ -140,8 +140,8 @@ void ResetProfileSettingsHandler::RegisterMessages() {

void ResetProfileSettingsHandler::HandleResetProfileSettings(

const base::ListValue* value) {

bool send_settings = false;

- if (!value->GetBoolean(0, &send_settings))

- NOTREACHED();

+ bool success = value->GetBoolean(0, &send_settings);

+ DCHECK(success);

DCHECK(brandcode_.empty() || config_fetcher_);

if (config_fetcher_ && config_fetcher_->IsActive()) {

« no previous file with comments | « chrome/browser/resources/settings/reset_page/reset_page.js ('k') | chrome/browser/ui/webui/settings/md_settings_ui.cc » ('j') | no next file with comments »