MD Settings: Migrating C++ handlers for profile reset page.

chrome/browser/resources/settings/reset_page/reset_page.css

Index: chrome/browser/resources/settings/reset_page/reset_page.css
diff --git a/chrome/browser/resources/settings/reset_page/reset_page.css b/chrome/browser/resources/settings/reset_page/reset_page.css
index 4db82b8c20a4d207cabfba789404cc5dcbd7ad68..942b61b8ce879361a578e51e58d76631a6509b92 100644
--- a/chrome/browser/resources/settings/reset_page/reset_page.css
+++ b/chrome/browser/resources/settings/reset_page/reset_page.css
@@ -3,8 +3,8 @@
  * found in the LICENSE file. */
 
 #resetDialog {
-  max-width: 500px;
-  min-width: 300px;
+  min-width; 300px;
+  width: 500px;
 }
 
 #reset {
@@ -28,8 +28,28 @@
   margin: 15px 0;
 }
 
-#sendSettings {
+#feedbackBar {
   background-color: rgb(236, 236, 236);
   margin: 0;
   padding: 20px;
 }
+
+#settings {
+  font-size: 12px;

[Dan Beam, 2015/11/09 23:05:18]

i think we generally use scale-able units (i.e. %)

[dpapad, 2015/11/09 23:37:48]

Done.

+  line-height: initial;

[Dan Beam, 2015/11/09 23:05:19]

what is this doing?

[dpapad, 2015/11/09 23:37:48]

http://imgur.com/a/pSIqv

+  table-layout: fixed;
+  width: 100%;
+}
+
+#settings .key {
+  color: #888;
+  padding-right: 5px;
+  text-align: right;

[Dan Beam, 2015/11/09 23:05:18]

RTL

[dpapad, 2015/11/09 23:37:49]

I prefer to address this in a separate CL.
 1) The "send settings" UI is a port of the options one, until we get finalized
mocks.
 2) Old Options UI does not seem to handle RTL here, (or it is handled in
someway I am not aware of), so I would need to investigate further.

[Dan Beam, 2015/11/09 23:42:03]

this CL is supposed to port functionality, mainly in C++ handlers, not the UI
that's a bug in the old settings UI that probably isn't worth fixing at this
point.  any code that goes into new settings probably would be.  but again: I
don't think this code should exist yet.

+  vertical-align: top;
+}
+
+#settings .value {
+  color: #333;
+  text-align: left;
+  white-space: pre-line;
+}

[Dan Beam, 2015/11/09 23:05:18]

i would do one of 2 things:
a) don't port over the "settings" (i.e. things sent when you reset) until we
have mocks
b) don't attempt to make it look user-facing at all if you are dead set on
porting that part

[dpapad, 2015/11/09 23:37:48]

Thanks for the advice, but now both a and b are done. Undoing either of them it
is more work, while
at the same time having a decently looking "send settings" UI is not a bad state
to be in.

[Dan Beam, 2015/11/09 23:42:03]

yes it is because people will think designers actually wanted it that way

[Dan Beam, 2015/11/10 01:41:30]

people = our team

[Dan Beam, 2015/11/10 01:57:45]

putting either a user-facing "OMG REMOVE THIS BEFORE WE LAUNCH" or stripping out
the CSS for this unapproved version sound good to me