MD Settings: Migrating C++ handlers for profile reset page.

chrome/browser/resources/settings/reset_page/reset_page.html

Index: chrome/browser/resources/settings/reset_page/reset_page.html
diff --git a/chrome/browser/resources/settings/reset_page/reset_page.html b/chrome/browser/resources/settings/reset_page/reset_page.html
index 211a0b8ef458866b16c2e26d26329170e2bf6a67..6e01b891d9acc066124d1ef6b50e6c78c423fee5 100644
--- a/chrome/browser/resources/settings/reset_page/reset_page.html
+++ b/chrome/browser/resources/settings/reset_page/reset_page.html
@@ -3,6 +3,7 @@
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-checkbox.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog/paper-dialog.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spinner.html">
 
 <dom-module id="settings-reset-page">
   <link rel="import" type="css"
@@ -14,14 +15,15 @@
       <div i18n-content="resetPageDescription"></div>
     </div>
 
-    <paper-dialog modal id="resetDialog" class="layout vertical">
-      <div id="top" class="layout vertical">
+    <paper-dialog modal id="resetDialog">

[Dan Beam, 2015/11/07 00:07:06]

we should dom-if this out when a reset is not in progress, or move this to a
separate dom-module, i.e. settings-reset-dialog or something, and instantiate
dynamically

[dpapad, 2015/11/07 00:31:08]

I am fine with making this its own polymer element if you think it is better.
But if this is for performance reasons, then we should think about this across
the whole new settings page and probably not start from here.

For example, the entire <settings-advanced-page> is in the DOM when in the
"basic" view, with display set to "none", similarly with this dialog. If we can
prove  that this makes things better, we should probably start by dynamically
adding the advanced page itself which is more heavy than this dialog.

[Dan Beam, 2015/11/07 00:52:00]

then do that next ;) but we should be hiding as much UI as possible until it's
needed.  i think this is a perfect example of something that will be used like
0.01% of the time users visit the settings page, and therefore shouldn't be
shown if possible

this doesn't need to block this CL as it's not hitting real users yet, but I'd
make these type of followups a priority

[dpapad, 2015/11/07 01:49:52]

Just to clarify, it is not shown unless user clicks on the "reset profile" row.
You probably meant that it should not be placed in the DOM at all (which
triggers all of the lifecycle methods of Polymer element, created, ready,
attached unnecessarily).

I am fine with converting this (and others to add elements to the DOM
programatically) in follow ups, but also, we should mention it during
our WebUI MD standups so that everyone is on board with it.

+      <div>
         <h2 i18n-content="resetPageTitle"></h2>
         <div i18n-content="resetPageExplanation" id="explanation"></div>
         <div class="layout center horizontal" id="buttonContainer">
           <paper-button on-tap="onLearnMoreTap_" id="learnMore"
               i18n-content="learnMore"></paper-button>
-          <div class="buttons flex-1">
+          <div class="layout center buttons flex-1">
+            <paper-spinner id="resetSpinner"></paper-spinner>
             <paper-button on-tap="onCancelTap_" id="cancel"
                 i18n-content="cancel"></paper-button>
             <paper-button i18n-content="resetPageCommit" on-tap="onResetTap_"
@@ -29,8 +31,20 @@
           </div>
         </div>
       </div>
-      <paper-checkbox id="sendSettings" i18n-content="resetPageFeedback"
-          checked></paper-checkbox>
+      <div id="feedbackBar">
+        <paper-checkbox id="sendSettings" i18n-content="resetPageFeedback"
+            checked on-change="onCheckboxChange_"></paper-checkbox>
+        <table id="settings">
+          <tbody>
+            <template is="dom-repeat" items="[[feedbackInfo]]">

[Dan Beam, 2015/11/07 00:07:05]

nit: can this be private?  i.e. feedbackInfo_

[dpapad, 2015/11/07 00:31:08]

My understanding  is that in order to use data binding, feedbackInfo needs to be
added in the properties section of the polymer element. Does the concept of
private apply to the properties section?

[Dan Beam, 2015/11/07 00:52:00]

yes

[dpapad, 2015/11/07 01:49:52]

Done.

+              <tr>
+                <td class="key">[[item.key]]</td>
+                <td class="value">[[item.value]]</td>
+              </tr>
+            </template>
+          </tbody>
+        </table>
+      </div>
     </paper-dialog>
 
   </template>