Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 14188030: Revert 194990 "Second take at handling users with locally overri..." (Closed)

Created:
7 years, 8 months ago by Peter Kasting
Modified:
7 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 194990 "Second take at handling users with locally overri..." > Second take at handling users with locally overridden diff-cmds. > > The first take at https://chromiumcodereview.appspot.com/14130006 tried to pass > "--diff-cmd diff", which doesn't work for e.g. Windows cmd users who don't have > a "diff" executable installed. > > This take instead passes the "--internal-diff" switch which tells svn to ignore > any diff-cmd set locally and use its internal diff engine at all times. > > While implementing this I found that the existing code tried to work around this > problem in a different way, by setting up a bogus config dir. Since that > doesn't seem to work for me, and shouldn't be necessary with this patch anyway, > removed that code. > > Review URL: https://chromiumcodereview.appspot.com/14050007 TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -69 lines) Patch
M trunk/tools/depot_tools/scm.py View 3 chunks +91 lines, -69 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
7 years, 8 months ago (2013-04-18 21:38:36 UTC) #1
Peter Kasting
7 years, 8 months ago (2013-04-18 21:38:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r195009.

Powered by Google App Engine
This is Rietveld 408576698