Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1559)

Unified Diff: base/float_util.h

Issue 14188028: Use std::isfinite(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: winblows Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/float_util.h
diff --git a/base/float_util.h b/base/float_util.h
index 31a307dbf5cc762ce8c7c7b07dfbbf82337613e1..c40c9f6b238ef160d541f2fd43a365a447ac3bdf 100644
--- a/base/float_util.h
+++ b/base/float_util.h
@@ -8,7 +8,7 @@
#include "build/build_config.h"
#include <float.h>
-#include <math.h>
+#include <cmath>
Mark Mentovai 2013/04/18 21:58:46 Blank line between C and C++ system headers.
namespace base {
@@ -17,7 +17,7 @@ inline bool IsFinite(const double& number) {
// isfinite isn't available on Android: http://b.android.com/34793
return finite(number) != 0;
Mark Mentovai 2013/04/18 21:58:46 Technically you need <math.h> for this on Android.
#elif defined(OS_POSIX)
- return isfinite(number) != 0;
+ return std::isfinite(number) != 0;
#elif defined(OS_WIN)
return _finite(number) != 0;
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698