Issue 14188028: Use std::isfinite().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14188028: Use std::isfinite(). (Closed)

Created:
7 years, 8 months ago by Nico

Modified:
7 years, 8 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use std::isfinite(). More standards-comformant, also needed for C++11 on Linux. BUG=233330 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195020

Patch Set 2 : ffffffffffffff #

Patch Set 4 : android? #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	base/float_util.h	View	1 2 3	1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://codereview.chromium.org/14188028/diff/9003/base/float_util.h File base/float_util.h (right): https://codereview.chromium.org/14188028/diff/9003/base/float_util.h#newcode11 base/float_util.h:11: #include <cmath> Blank line between C and C++ ...

7 years, 8 months ago (2013-04-18 21:58:46 UTC) #2

Nico

It looks like Android can use std::isinfinite() too, so I switched Android to that. I ...

7 years, 8 months ago (2013-04-18 22:10:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14188028/11003

7 years, 8 months ago (2013-04-18 22:10:35 UTC) #4

Nico

7 years, 8 months ago (2013-04-18 22:47:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r195020 (presubmit successful).