CRX FileSystem Pepper private API

ppapi/proxy/ext_crx_file_system_private_resource.h

Index: ppapi/proxy/ext_crx_file_system_private_resource.h
diff --git a/ppapi/proxy/ext_crx_file_system_private_resource.h b/ppapi/proxy/ext_crx_file_system_private_resource.h
new file mode 100644
index 0000000000000000000000000000000000000000..736829fa6a20f05baefde143ace5de6a8f025e1a
--- /dev/null
+++ b/ppapi/proxy/ext_crx_file_system_private_resource.h
@@ -0,0 +1,71 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// CRX filesystem is a filesystem that allows an extension to read its own

[yzshen1, 2013/04/30 19:31:19]

nit: I think it is better to put this comment right above the Class declaration.
At least it should below #ifndef/#define and #include.

+// package directory tree.  See ppapi/examples/crxfs for example.
+//
+// IMPLEMENTATION
+//
+// The implementation involves both browser and renderer.  In order to provide
+// readonly access to CRX filesystem (i.e. extension directory), we create an
+// "isolated filesystem" points to current extension directory in browser.

[yzshen1, 2013/04/30 19:31:19]

points -> pointing

[victorhsieh, 2013/04/30 22:04:32]

Done.

+// Then browser grants read permission to renderer.
+//
+// The only purpose of renderer is make it accessible by FileRef, which runs in

[yzshen1, 2013/04/30 19:31:19]

renderer -> renderer CRX filesystem resource host?

is make -> is to make

[victorhsieh, 2013/04/30 22:04:32]

Done.

+// renderer at this time.
+//
+// When the plugin calls PPB_Ext_CrxFileSystem_Private_API.Open, the resource
+// class ExtCrxFileSystemPrivateResource forwards the request to the browser
+// host.  Once the browser host successfully create the underlying "isolated

[yzshen1, 2013/04/30 19:31:19]

create -> creates

[victorhsieh, 2013/04/30 22:04:32]

Done.

+// filesystem", it replies to the resource with filesystem id and current
+// extension id, which are then sent to renderer host for FileRef to access.
+
+#ifndef PPAPI_PROXY_EXT_CRX_FILE_SYSTEM_PRIVATE_RESOURCE_H_
+#define PPAPI_PROXY_EXT_CRX_FILE_SYSTEM_PRIVATE_RESOURCE_H_
+
+#include <string>
+
+#include "base/memory/ref_counted.h"
+#include "ppapi/proxy/connection.h"
+#include "ppapi/proxy/plugin_resource.h"
+#include "ppapi/proxy/ppapi_proxy_export.h"
+#include "ppapi/thunk/ppb_ext_crx_file_system_private_api.h"
+
+namespace ppapi {
+
+class TrackedCallback;
+
+namespace proxy {
+
+class ResourceMessageReplyParams;
+
+class PPAPI_PROXY_EXPORT ExtCrxFileSystemPrivateResource
+    : public PluginResource,
+      public thunk::PPB_Ext_CrxFileSystem_Private_API {
+ public:
+  ExtCrxFileSystemPrivateResource(Connection connection, PP_Instance instance);
+  virtual ~ExtCrxFileSystemPrivateResource();
+
+  // Resource overrides.
+  virtual thunk::PPB_Ext_CrxFileSystem_Private_API*
+      AsPPB_Ext_CrxFileSystem_Private_API() OVERRIDE;
+
+  // PPB_Ext_CrxFileSystem_Private_API implementation.
+  virtual int32_t Open(scoped_refptr<TrackedCallback> callback) OVERRIDE;
+
+ private:
+  void OnBrowserOpenComplete(scoped_refptr<TrackedCallback> callback,
+                             const ResourceMessageReplyParams& params,
+                             const std::string& origin,
+                             const std::string& fsid);
+  void OnRendererOpenComplete(scoped_refptr<TrackedCallback> callback,
+                              const ResourceMessageReplyParams& params);
+
+  DISALLOW_COPY_AND_ASSIGN(ExtCrxFileSystemPrivateResource);
+};
+
+}  // namespace proxy
+}  // namespace ppapi
+
+#endif  // PPAPI_PROXY_EXT_CRX_FILE_SYSTEM_PRIVATE_RESOURCE_H_