ppapi/thunk/ppb_file_ref_thunk.cc - Issue 14188019: CRX FileSystem Pepper private API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/thunk/ppb_file_ref_thunk.cc

Issue 14188019: CRX FileSystem Pepper private API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/thunk/ppb_file_ref_thunk.cc

diff --git a/ppapi/thunk/ppb_file_ref_thunk.cc b/ppapi/thunk/ppb_file_ref_thunk.cc

index 3c56c5cabc3cfbea44e6ca15773bf0f965f55481..15314ee46a04f13d80d6337297f863ef846a97be 100644

--- a/ppapi/thunk/ppb_file_ref_thunk.cc

+++ b/ppapi/thunk/ppb_file_ref_thunk.cc

@@ -24,7 +24,9 @@ typedef EnterResource<PPB_FileRef_API> EnterFileRef;

PP_Resource Create(PP_Resource file_system, const char* path) {

ppapi::ProxyAutoLock lock;

- EnterResourceNoLock<PPB_FileSystem_API> enter_file_system(file_system, true);

+ // Make sure the file_system is one of the expected types.

+ EnterResourceNoLock<PPB_FileSystem_API> enter_file_system(file_system, false);

yzshen1 2013/05/06 17:34:57 Now you could use 'true' again. :P (reverting all

victorhsieh 2013/05/06 18:32:02 Done.

if (enter_file_system.failed())

return 0;

PP_Instance instance = enter_file_system.resource()->pp_instance();