ppapi/cpp/private/ext_crx_file_system_private.h - Issue 14188019: CRX FileSystem Pepper private API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/cpp/private/ext_crx_file_system_private.h

Issue 14188019: CRX FileSystem Pepper private API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ppapi/cpp/private/ext_crx_file_ref_private.h ('K') | « ppapi/cpp/private/ext_crx_file_ref_private.h ('k') | ppapi/cpp/private/ext_crx_file_system_private.cc » ('j') | ppapi/proxy/ext_crx_file_system_private_resource.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef PPAPI_CPP_PRIVATE_EXTENSION_CRX_FILE_SYSTEM_PRIVATE_H_

	6 #define PPAPI_CPP_PRIVATE_EXTENSION_CRX_FILE_SYSTEM_PRIVATE_H_

	7

	8 #include "ppapi/c/pp_instance.h"

	9 #include "ppapi/cpp/instance_handle.h"

	10 #include "ppapi/cpp/resource.h"

	11

	12 namespace pp {

	13

	14 class CompletionCallback;

	15

	16 class ExtCrxFileSystemPrivate : public Resource {

	17 public:

	18 ExtCrxFileSystemPrivate();

	19 ExtCrxFileSystemPrivate(const InstanceHandle& instance);
	teravest 2013/04/18 16:10:38 explicit explicit victorhsieh 2013/04/18 19:28:38 Done. Show quoted text On 2013/04/18 16:10:38, teravest wrote: > explicit Done.
	20 ExtCrxFileSystemPrivate(const ExtCrxFileSystemPrivate& other);
	teravest 2013/04/18 16:10:38 explicit explicit victorhsieh 2013/04/18 19:28:38 Done. Show quoted text On 2013/04/18 16:10:38, teravest wrote: > explicit Done.
	21 virtual ~ExtCrxFileSystemPrivate();

	22

	23 int32_t Open(const CompletionCallback& cc);
	teravest 2013/04/18 16:10:38 It looks like this can probably be const? It looks like this can probably be const? victorhsieh 2013/04/18 19:28:38 For the current implementation, yes. But I'd safe Show quoted text On 2013/04/18 16:10:38, teravest wrote: > It looks like this can probably be const? For the current implementation, yes. But I'd safe not making it a const as future change may make this "open" non-const.
	24 };

	25

	26 } // namespace pp

	27

	28 #endif // PPAPI_CPP_PRIVATE_EXTENSION_CRX_FILE_SYSTEM_PRIVATE_H_

OLD	NEW