CRX FileSystem Pepper private API

ppapi/api/private/ppb_ext_crx_file_system_private.idl

+/* Copyright (c) 2013 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+[generate_thunk]
+
+/**
+ * This file contains the <code>PPB_Ext_CrxFileSystem_Private</code> interface.
+ */
+label Chrome {
+  M28 = 0.1
+};
+
+/* <code>PPB_Ext_CrxFileSystem_Private</code> interface */
+interface PPB_Ext_CrxFileSystem_Private {
+  /**
+   * Create() creates a CRX filesystem resource.  It may fail when called from
+   * non-extension context.
+   */
+  PP_Resource Create([in] PP_Instance insance);

[yzshen1, 2013/05/02 23:22:01]

You don't need to Create this PP_Resource and instead use the PP_Instance in
Open(). (I am fine if you would like to keep it, but you have also added
singleton resource-related code.)

[victorhsieh, 2013/05/03 17:26:58]

Done.

+
+  /**
+   * Open() opens the CRX file system for the current extension.  It will fail
+   * when called from non-extension context.
+   *
+   * @param[in] crxfs A <code>PP_Resource</code> corresponding to a
+   * CrxFileSystem.
+   * @param[out] file_system An output <code>PP_Resource</code> corresponding
+   * to a FileSystem.

[yzshen1, 2013/05/02 23:22:01]

Please be more specific saying that it is a PPB_FileSystem.

[victorhsieh, 2013/05/03 17:26:58]

Done.

+   * @param[in] callback A <code>PP_CompletionCallback</code> to be called upon
+   * completion of Open.
+   *
+   * @return An int32_t containing an error code from <code>pp_errors.h</code>.
+   */
+  int32_t Open([in] PP_Resource crxfs,
+               [out] PP_Resource file_system,
+               [in] PP_CompletionCallback callback);
+};