CRX FileSystem Pepper private API

content/renderer/pepper/pepper_file_system_host.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_file_system_host.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "content/common/child_thread.h"
 #include "content/common/fileapi/file_system_dispatcher.h"
 #include "content/public/renderer/renderer_ppapi_host.h"
 #include "content/renderer/pepper/null_file_system_callback_dispatcher.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/host/dispatch_host_message.h"
 #include "ppapi/host/ppapi_host.h"
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ppapi/shared_impl/file_type_conversion.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebElement.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPluginContainer.h"
+#include "webkit/fileapi/file_system_util.h"
 #include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
 
 namespace content {
 
 namespace {
 
 class PlatformCallbackAdaptor : public NullFileSystemCallbackDispatcher {
  public:
   explicit PlatformCallbackAdaptor(
       const base::WeakPtr<PepperFileSystemHost>& weak_host)
@@ skipping 11 matching lines @@
     if (weak_host_) {
       weak_host_->OpenFileSystemReply(
           ppapi::PlatformFileErrorToPepperError(platform_error), GURL());
     }
   }
 
  private:
   base::WeakPtr<PepperFileSystemHost> weak_host_;
 };
 
+bool LooksLikeAGuid(const std::string& fsid) {
+  const int kExpectedFsIdSize = 32;

[palmer, 2013/05/02 21:30:09]

std::string::size returns std::string::size_type, which is size_t. So declare
this as a size_t.

I doubt it matters, but you could make it static too.

[victorhsieh, 2013/05/03 17:26:58]

Done.
I prefer not to, as my first doubt of static here is.. the this value will be
kept/shared for the next call.  But of course it doesn't matter, or is likely be
optimized out as it's a const.

+  if (fsid.size() != kExpectedFsIdSize)
+    return false;
+  for (std::string::const_iterator it = fsid.begin(); it != fsid.end(); ++it) {
+    if (('A' <= *it && *it <= 'F') ||
+        ('0' <= *it && *it <= '9'))
+      continue;
+    return false;
+  }
+  return true;
+}
+
 }  // namespace
 
 PepperFileSystemHost::PepperFileSystemHost(RendererPpapiHost* host,
                                            PP_Instance instance,
                                            PP_Resource resource,
                                            PP_FileSystemType type)
     : ResourceHost(host->GetPpapiHost(), instance, resource),
       renderer_ppapi_host_(host),
       weak_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)),
       type_(type),
       opened_(false),
       called_open_(false) {
+  ppapi::host::FileSystemRegistry::GetInstance()->Register(pp_instance(),
+                                                           pp_resource(),
+                                                           this);
 }
 
 PepperFileSystemHost::~PepperFileSystemHost() {
+  ppapi::host::FileSystemRegistry::GetInstance()->Unregister(pp_instance(),
+                                                             pp_resource());
 }
 
 int32_t PepperFileSystemHost::OnResourceMessageReceived(
     const IPC::Message& msg,
     ppapi::host::HostMessageContext* context) {
   IPC_BEGIN_MESSAGE_MAP(PepperFileSystemHost, msg)
-    PPAPI_DISPATCH_HOST_RESOURCE_CALL(PpapiHostMsg_FileSystem_Open,
-                                      OnHostMsgOpen)
+    PPAPI_DISPATCH_HOST_RESOURCE_CALL(
+        PpapiHostMsg_FileSystem_Open,
+        OnHostMsgOpen)
+    PPAPI_DISPATCH_HOST_RESOURCE_CALL(
+        PpapiHostMsg_FileSystem_InitIsolatedFileSystem,
+        OnHostMsgInitIsolatedFileSystem)
   IPC_END_MESSAGE_MAP()
   return PP_ERROR_FAILED;
 }
 
+PP_FileSystemType PepperFileSystemHost::GetType() const {
+  return type_;
+}
+
+bool PepperFileSystemHost::IsOpened() const {
+  return opened_;
+}
+
+const GURL& PepperFileSystemHost::GetRootUrl() const {
+  return root_url_;
+}
+
 void PepperFileSystemHost::OpenFileSystemReply(int32_t pp_error,
                                                const GURL& root) {
   opened_ = (pp_error == PP_OK);
   root_url_ = root;
   reply_context_.params.set_result(pp_error);
   host()->SendReply(reply_context_,
                     PpapiPluginMsg_FileSystem_OpenReply());
   reply_context_ = ppapi::host::ReplyMessageContext();
 }
 
@@ skipping 32 matching lines @@
       GURL(plugin_instance->container()->element().document().url()).
           GetOrigin(),
       file_system_type, expected_size, true /* create */,
       new PlatformCallbackAdaptor(weak_factory_.GetWeakPtr()))) {
     return PP_ERROR_FAILED;
   }
 
   return PP_OK_COMPLETIONPENDING;
 }
 
+int32_t PepperFileSystemHost::OnHostMsgInitIsolatedFileSystem(
+    ppapi::host::HostMessageContext* context,
+    const std::string& fsid) {
+  // sanity check
+  if (!LooksLikeAGuid(fsid))
+    return PP_ERROR_BADARGUMENT;
+  const GURL& url =
+      renderer_ppapi_host_->GetDocumentURLForInstance(pp_instance());
+  root_url_ = GURL(fileapi::GetIsolatedFileSystemRootURIString(
+      url.GetWithEmptyPath(), fsid, "crxfs"));
+  opened_ = true;
+  return PP_OK;
+}
+
 }  // namespace content