Issue 14188014: Rename NativePanelStack to NativePanelStackWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14188014: Rename NativePanelStack to NativePanelStackWindow (Closed)

Created:
7 years, 8 months ago by jianli

Modified:
7 years, 8 months ago

Reviewers:
Nico, Dmitry Titov

CC:
chromium-reviews, tfarina, jennb, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename NativePanelStack to NativePanelStackWindow We're going to change to use more than one background windows to enclose panels in the stack because not all panels are fully aligned when some of them are being dragged. The 'Window' suffix is added to the naming to make it clear. BUG=223155 TEST=none due to no functionality change TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194666

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -93 lines)			Patch
D	chrome/browser/ui/panels/native_panel_stack.h	View	1 chunk	+0 lines, -53 lines	0 comments	Download
D	chrome/browser/ui/panels/native_panel_stack.cc	View	1 chunk	+0 lines, -16 lines	0 comments	Download
A +	chrome/browser/ui/panels/native_panel_stack_window.h	View	4 chunks	+12 lines, -10 lines	0 comments	Download
A +	chrome/browser/ui/panels/native_panel_stack_window.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/panels/stacked_panel_collection.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/panels/stacked_panel_collection.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/panels/panel_stack_view.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/panels/panel_stack_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

gypi lgtm

Expand Messages | Collapse Messages