Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 14188008: Move Data uri handling into WebCore

Created:
7 years, 8 months ago by pdr.
Modified:
7 years, 7 months ago
Reviewers:
CC:
blink-reviews, jamesr, Nate Chapin, jeez, abarth_chromum.org, gavinp+loader_chromium.org
Visibility:
Public.

Description

Move Data uri handling into WebCore ** this patch is not yet ready for review ** This patch moves data url handling to WebCore from its previous home in in weburlloader_impl.cc. SVG images are sandboxed to prevent network loads (images loading other images) but we should whitelist data uris. Passing a null networking context into weburlloader has been a source of security bugs in the past. This patch hooks data uri handling in ResourceLoader and uses the substitute resource architecture to deliver data uri resources. BUG=224317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -27 lines) Patch
M Source/Platform/chromium/public/Platform.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/WebCore.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/WebCore/loader/DataUriResource.h View 1 chunk +8 lines, -16 lines 0 comments Download
A + Source/WebCore/loader/DataUriResource.cpp View 1 chunk +7 lines, -10 lines 0 comments Download
M Source/WebCore/loader/DocumentLoader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/loader/DocumentLoader.cpp View 3 chunks +17 lines, -0 lines 0 comments Download
M Source/WebCore/loader/ResourceLoader.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebCore/loader/cache/CachedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/network/ResourceHandle.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/platform/network/chromium/ResourceHandle.cpp View 1 chunk +16 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698