Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 14188004: Remove UserScript support, which is not used by Chromium (Closed)

Created:
7 years, 8 months ago by adamk
Modified:
7 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, Nate Chapin, gavinp+loader_chromium.org, jochen+watch_chromium.org, abarth_chromum.org, Aaron Boodman, Matt Perry
Visibility:
Public.

Description

Remove UserScript support, which is not used by Chromium Though the Chromium/WebKit API exposes the addUserScript method, it's only ever called by the TestRunner. Nearly all the tests under userscripts/ were simply testing the behavior of PageGroup::addUserScript, but since Chromium doesn't use this in non-test code, these tests can safely be deleted. Also deleted related code in Frame, FrameLoader, and various other addUser* methods not used by Chromium or WebCore. For those tests that were exercising addUserStylesheet, I've moved them to LayoutTests/userstyles. For the few tests that were actually just testing isolated world behavior, I've moved them to fast/events. Besides deleting dead code, this patch gets rid of one usage of temporary isolated worlds (see attached bug). R=abarth BUG=230460 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148237

Patch Set 1 #

Patch Set 2 : Remove one more test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -921 lines) Patch
A + LayoutTests/fast/events/window-onerror-for-isolated-world-1.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/events/window-onerror-for-isolated-world-1-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
A + LayoutTests/fast/events/window-onerror-for-isolated-world-2.html View 2 chunks +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/events/window-onerror-for-isolated-world-2-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/platform/chromium/TestExpectations View 2 chunks +0 lines, -7 lines 0 comments Download
D LayoutTests/platform/chromium/userscripts/script-run-at-end-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/plugins/plugin-document-load-prevented-userscript.html View 1 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/plugins/plugin-document-load-prevented-userscript-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/userscripts/document-element-available-at-start.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/userscripts/document-element-available-at-start-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/userscripts/insert-stylesheets.html View 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/userscripts/insert-stylesheets-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/userscripts/mixed-case-stylesheet.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/userscripts/mixed-case-stylesheet-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/userscripts/resources/abe.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/userscripts/resources/blank.xhtml View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/userscripts/resources/frame1.html View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/userscripts/resources/frame2.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/userscripts/resources/silence-loop.mov View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/userscripts/resources/test.wav View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/userscripts/script-not-run-for-fragments.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/userscripts/script-not-run-for-fragments-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/userscripts/script-run-at-end.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/userscripts/script-run-at-start.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/userscripts/script-run-at-start-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/userscripts/simple-stylesheet.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/userscripts/simple-stylesheet-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/userscripts/user-script-all-frames.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/userscripts/user-script-all-frames-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/userscripts/user-script-audio-document.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/userscripts/user-script-audio-document-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/userscripts/user-script-image-document.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/userscripts/user-script-image-document-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/userscripts/user-script-plugin-document.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/userscripts/user-script-plugin-document-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/userscripts/user-script-top-frame-only.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/userscripts/user-script-top-frame-only-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/userscripts/user-script-video-document.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/userscripts/user-script-video-document-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/userscripts/user-style-all-frames.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/userscripts/user-style-all-frames-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/userscripts/user-style-top-frame-only.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/userscripts/user-style-top-frame-only-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/userscripts/user-stylesheet-invalidate.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/userscripts/user-stylesheet-invalidate-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/userscripts/window-onerror-for-isolated-world-1.html View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/userscripts/window-onerror-for-isolated-world-1-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/userscripts/window-onerror-for-isolated-world-2.html View 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/userscripts/window-onerror-for-isolated-world-2-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
A + LayoutTests/userstyles/insert-stylesheets.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/insert-stylesheets-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/mixed-case-stylesheet.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/mixed-case-stylesheet-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/resources/frame1.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/resources/frame2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/simple-stylesheet.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/simple-stylesheet-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/user-style-all-frames.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/user-style-all-frames-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/user-style-top-frame-only.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/user-style-top-frame-only-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/user-stylesheet-invalidate.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/userstyles/user-stylesheet-invalidate-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/loader/FrameLoader.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/page/Frame.h View 3 chunks +0 lines, -5 lines 0 comments Download
M Source/WebCore/page/Frame.cpp View 1 chunk +0 lines, -38 lines 0 comments Download
M Source/WebCore/page/PageGroup.h View 3 chunks +0 lines, -11 lines 0 comments Download
M Source/WebCore/page/PageGroup.cpp View 2 chunks +0 lines, -97 lines 0 comments Download
D Source/WebCore/page/UserScript.h View 1 chunk +0 lines, -73 lines 0 comments Download
D Source/WebCore/page/UserScriptTypes.h View 1 chunk +0 lines, -44 lines 0 comments Download
M Source/WebKit/chromium/public/WebView.h View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/WebKit/chromium/src/AssertMatchingEnums.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h View 1 chunk +1 line, -2 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
adamk
7 years, 8 months ago (2013-04-11 20:45:04 UTC) #1
abarth-chromium
Great! LGTM.
7 years, 8 months ago (2013-04-11 20:49:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14188004/3002
7 years, 8 months ago (2013-04-11 20:57:59 UTC) #3
commit-bot: I haz the power
Presubmit check for 14188004-3002 failed and returned exit status -2001. The presubmit check was hung. ...
7 years, 8 months ago (2013-04-11 21:04:31 UTC) #4
adamk
7 years, 8 months ago (2013-04-11 23:02:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r148237 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698