Issue 14188002: Only use JDCT_FAST if it is supported in jpeg.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14188002: Only use JDCT_FAST if it is supported in jpeg. (Closed)

Created:
7 years, 8 months ago by scroggo

Modified:
7 years, 8 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Only use JDCT_FAST if it is supported in jpeg. Fixes a bug where jpeg decoder did not work on linux. Committed: https://code.google.com/p/skia/source/detail?r=8661

Patch Set 2 : Respond to comment #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/images/SkImageDecoder_libjpeg.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

djsollen

lgtm with a one nit. https://codereview.chromium.org/14188002/diff/1/src/images/SkImageDecoder_libjpeg.cpp File src/images/SkImageDecoder_libjpeg.cpp (right): https://codereview.chromium.org/14188002/diff/1/src/images/SkImageDecoder_libjpeg.cpp#newcode276 src/images/SkImageDecoder_libjpeg.cpp:276: cinfo.dct_method = JDCT_ISLOW; for ...

7 years, 8 months ago (2013-04-12 15:51:50 UTC) #2

scroggo

https://codereview.chromium.org/14188002/diff/1/src/images/SkImageDecoder_libjpeg.cpp File src/images/SkImageDecoder_libjpeg.cpp (right): https://codereview.chromium.org/14188002/diff/1/src/images/SkImageDecoder_libjpeg.cpp#newcode276 src/images/SkImageDecoder_libjpeg.cpp:276: cinfo.dct_method = JDCT_ISLOW; On 2013/04/12 15:51:51, djsollen wrote: > ...

7 years, 8 months ago (2013-04-12 15:57:01 UTC) #3

scroggo

7 years, 8 months ago (2013-04-12 16:28:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r8661 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14188002: Only use JDCT_FAST if it is supported in jpeg. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Respond to comment #

Messages