chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 1418763002: Revert of Eliminate //chrome dependencies from MetricsServicesManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1418763002: Revert of Eliminate //chrome dependencies from MetricsServicesManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | chrome/browser/metrics/chrome_metrics_services_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index 5ffa6f6cb5dcfa73050f0ddb857484b24d3a5291..433978a07b4fbc40a945dca78a9612d79dcf4db6 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -179,10 +179,6 @@

#endif // defined(ENABLE_PLUGINS)

}

-metrics::MetricsService* ChromeMetricsServiceClient::GetMetricsService() {

- return metrics_service_.get();

void ChromeMetricsServiceClient::SetMetricsClientId(

const std::string& client_id) {

crash_keys::SetMetricsClientIdFromGUID(client_id);

@@ -280,7 +276,7 @@

#endif

}

-void ChromeMetricsServiceClient::OnPluginLoadingError(

+void ChromeMetricsServiceClient::LogPluginLoadingError(

const base::FilePath& plugin_path) {

#if defined(ENABLE_PLUGINS)

plugin_metrics_provider_->LogPluginLoadingError(plugin_path);