Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: src/compiler/js-inlining.cc

Issue 1418693005: Fix gcc 4.9.2 signed-compare error. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-inlining.cc
diff --git a/src/compiler/js-inlining.cc b/src/compiler/js-inlining.cc
index 5f68c006781c5c6aa73be74d08d4e855da8b5e39..2cf23c7ee3d0025f3c2be994bb56320dd669421e 100644
--- a/src/compiler/js-inlining.cc
+++ b/src/compiler/js-inlining.cc
@@ -414,7 +414,8 @@ Reduction JSInliner::ReduceJSCallFunction(Node* node,
// Insert argument adaptor frame if required. The callees formal parameter
// count (i.e. value outputs of start node minus target, receiver & context)
// have to match the number of arguments passed to the call.
- DCHECK_EQ(parameter_count, start->op()->ValueOutputCount() - 3);
+ DCHECK_EQ(static_cast<int32_t>(parameter_count),
paul.l... 2015/10/22 18:49:03 nit: ValueOutputCount() is 'int', seems we should
akos.palfi.imgtec 2015/10/22 18:59:14 Done.
+ start->op()->ValueOutputCount() - 3);
if (call.formal_arguments() != parameter_count) {
frame_state = CreateArgumentsAdaptorFrameState(&call, info.shared_info());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698